Issue 7283039: Fix SConstruct to pass correct defines to samples/preparser when building with library=shared.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7283039: Fix SConstruct to pass correct defines to samples/preparser when building with library=shared. (Closed)

Created:
9 years, 5 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 5 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix SConstruct to pass correct defines to samples/preparser when building with library=shared. Fix shell sample build with library=library. R=ager@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=8485

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -13 lines)			Patch
	M	SConstruct	View		6 chunks	+10 lines, -10 lines	0 comments	Download
	M	samples/shell.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM, thanks!