Issue 7283034: Trivial fix to work WebUI TaskManager correctly on trunk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7283034: Trivial fix to work WebUI TaskManager correctly on trunk (Closed)

Created:
9 years, 5 months ago by yoshiki

Modified:
9 years, 5 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Trivial fix to work WebUI TaskManager correctly on trunk BUG=chromium-os:13885 TEST=manual on chromium-os Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91093

Patch Set 1 #

Patch Set 2 : Reorder loading orders of Javascripts. #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -7 lines)			Patch
	M	chrome/browser/resources/task_manager/main.html	View	1	1 chunk	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hashimoto

On 2011/06/30 05:24:48, yoshiki wrote: > please review it! LGTM

9 years, 5 months ago (2011-06-30 05:30:57 UTC) #2

yoshiki

Sorry, the patch set 1 does not work correctly because of dependency on JavaScripts. Please ...

9 years, 5 months ago (2011-06-30 05:56:14 UTC) #3

hashimoto

9 years, 5 months ago (2011-06-30 06:09:11 UTC) #4

On 2011/06/30 05:56:14, yoshiki wrote:
> Sorry, the patch set 1 does not work correctly because of dependency on
> JavaScripts. Please review it again.
> 
> On 2011/06/30 05:30:57, hashimoto wrote:
> > On 2011/06/30 05:24:48, yoshiki wrote:
> > > please review it!
> > 
> > LGTM

LGTM again

Expand Messages | Collapse Messages