chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.cc - Issue 7283022: Make a clean interface for dialog callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.cc

Issue 7283022: Make a clean interface for dialog callbacks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.cc

diff --git a/chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.cc b/chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.cc

index fe0ee4355b043ba95b0c66377c0698cb313f5abb..1d09850be0bcc3c0727dd71f0e0db6bdb3088942 100644

--- a/chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.cc

+++ b/chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.cc

@@ -11,7 +11,7 @@ void AppModalDialogQueue::AddDialog(AppModalDialog* dialog) {

ShowModalDialog(dialog);

return;

}

- app_modal_dialog_queue_.push(dialog);

+ app_modal_dialog_queue_.push_back(dialog);

}

void AppModalDialogQueue::ShowNextDialog() {

@@ -60,7 +60,7 @@ void AppModalDialogQueue::ShowModalDialog(AppModalDialog* dialog) {

AppModalDialog* AppModalDialogQueue::GetNextDialog() {

while (!app_modal_dialog_queue_.empty()) {

AppModalDialog* dialog = app_modal_dialog_queue_.front();

- app_modal_dialog_queue_.pop();

+ app_modal_dialog_queue_.pop_front();

if (dialog->IsValid())

return dialog;

delete dialog;