Make a clean interface for dialog callbacks.

chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h

Index: chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h
diff --git a/chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h b/chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h
index be24a744112cdcbc7f56c038891ed7eb5a9f6dfd..585700230fe3888120ef2844930e352da32de33a 100644
--- a/chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h
+++ b/chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h
@@ -6,7 +6,7 @@
 #define CHROME_BROWSER_UI_APP_MODAL_DIALOGS_APP_MODAL_DIALOG_QUEUE_H_
 #pragma once
 
-#include <queue>
+#include <deque>
 
 #include "chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h"
 
@@ -56,6 +56,16 @@ class AppModalDialogQueue {
     return active_dialog_;
   }
 
+  // Iterators to walk the queue.
+  typedef std::deque<AppModalDialog*>::iterator iterator;
+  iterator begin() {
+    return app_modal_dialog_queue_.begin();
+  }
+
+  iterator end() {
+    return app_modal_dialog_queue_.end();
+  }
+
  private:
   friend struct DefaultSingletonTraits<AppModalDialogQueue>;
 
@@ -73,7 +83,7 @@ class AppModalDialogQueue {
 
   // Contains all app modal dialogs which are waiting to be shown, with the
   // currently modal dialog at the front of the queue.
-  std::queue<AppModalDialog*> app_modal_dialog_queue_;
+  std::deque<AppModalDialog*> app_modal_dialog_queue_;

[Evan Martin, 2011/06/29 22:01:52]

This change is unrelated to the refactoring, no?

[Avi (use Gerrit), 2011/06/29 22:09:29]

Required. The refactoring requires the ability to walk over the queue, and
std::queue doesn't let you.

 
   // The currently active app-modal dialog box's delegate. NULL if there is no
   // active app-modal dialog box.