Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Side by Side Diff: chrome/browser/extensions/extension_host.h

Issue 7283022: Make a clean interface for dialog callbacks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 // NotificationObserver 185 // NotificationObserver
186 virtual void Observe(NotificationType type, 186 virtual void Observe(NotificationType type,
187 const NotificationSource& source, 187 const NotificationSource& source,
188 const NotificationDetails& details); 188 const NotificationDetails& details);
189 189
190 // Overridden from content::JavaScriptDialogDelegate: 190 // Overridden from content::JavaScriptDialogDelegate:
191 virtual void OnDialogClosed(IPC::Message* reply_msg, 191 virtual void OnDialogClosed(IPC::Message* reply_msg,
192 bool success, 192 bool success,
193 const string16& user_input) OVERRIDE; 193 const string16& user_input) OVERRIDE;
194 virtual gfx::NativeWindow GetDialogRootWindow() OVERRIDE; 194 virtual gfx::NativeWindow GetDialogRootWindow() OVERRIDE;
195 virtual TabContents* AsTabContents() OVERRIDE;
196 virtual ExtensionHost* AsExtensionHost() OVERRIDE;
197 195
198 protected: 196 protected:
199 // Internal functions used to support the CreateNewWidget() method. If a 197 // Internal functions used to support the CreateNewWidget() method. If a
200 // platform requires plugging into widget creation at a lower level, then a 198 // platform requires plugging into widget creation at a lower level, then a
201 // subclass might want to override these functions, but otherwise they should 199 // subclass might want to override these functions, but otherwise they should
202 // be fine just implementing RenderWidgetHostView::InitAsPopup(). 200 // be fine just implementing RenderWidgetHostView::InitAsPopup().
203 // 201 //
204 // The Create function returns the newly created widget so it can be 202 // The Create function returns the newly created widget so it can be
205 // associated with the given route. When the widget needs to be shown later, 203 // associated with the given route. When the widget needs to be shown later,
206 // we'll look it up again and pass the object to the Show functions rather 204 // we'll look it up again and pass the object to the Show functions rather
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 // Used to measure how long it's been since the host was created. 285 // Used to measure how long it's been since the host was created.
288 PerfTimer since_created_; 286 PerfTimer since_created_;
289 287
290 // FileSelectHelper, lazily created. 288 // FileSelectHelper, lazily created.
291 scoped_ptr<FileSelectHelper> file_select_helper_; 289 scoped_ptr<FileSelectHelper> file_select_helper_;
292 290
293 DISALLOW_COPY_AND_ASSIGN(ExtensionHost); 291 DISALLOW_COPY_AND_ASSIGN(ExtensionHost);
294 }; 292 };
295 293
296 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_ 294 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698