Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 7283013: Deleted gl.gyp that had duplicate ppapi_egl target. (Closed)

Created:
9 years, 5 months ago by alokp%chromium.org
Modified:
9 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Deleted gl.gyp that had duplicate ppapi_egl target. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91320

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -59 lines) Patch
D ppapi/lib/gl/gl.gyp View 1 chunk +0 lines, -55 lines 0 comments Download
M ppapi/ppapi_gl.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
alokp
9 years, 5 months ago (2011-06-29 17:42:29 UTC) #1
brettw
LGTM
9 years, 5 months ago (2011-06-29 18:03:04 UTC) #2
noelallen_use_chromium
LGTM
9 years, 5 months ago (2011-06-29 20:33:23 UTC) #3
commit-bot: I haz the power
9 years, 5 months ago (2011-06-30 20:18:14 UTC) #4
Presubmit check for 7283013-2002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
alokp%chromium.org@gtempaccount.com is not in AUTHORS file. If you are a new
contributor, please visit
http://www.chromium.org/developers/contributing-code and read the "Legal"
section
If you are a chromite, verify the contributor signed the CLA.

Presubmit checks took 1.0s to calculate.

Powered by Google App Engine
This is Rietveld 408576698