Remove more unnecessary ChromeURLRequestContext members.

chrome/browser/browser_main.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_main.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 1990 matching lines @@
       // Call Recycle() here as late as possible, before going into the loop
       // because Start() will add things to it while creating the main window.
       if (pool)
         pool->Recycle();
 
       UMA_HISTOGRAM_MEDIUM_TIMES("Startup.BrowserOpenTabs",
                                  base::TimeTicks::Now() - browser_open_start);
 
       // If we're running tests (ui_task is non-null), then we don't want to
       // call FetchLanguageListFromTranslateServer
-      if (parameters.ui_task == NULL && translate_manager != NULL)
+      if (parameters.ui_task == NULL && translate_manager != NULL) {
+        // TODO(willchan): Get rid of this after TranslateManager doesn't use
+        // the default request context. http://crbug.com/89396.
+        // This is necessary to force |default_request_context_| to be
+        // initialized.
+        profile->GetRequestContext();

[Dmitry Polukhin, 2011/07/18 08:47:23]

It looks like removing this line broke Chrome on Chrome OS on login screen.
[12795:12795:1542236166900:FATAL:url_fetcher.cc(558)] Check failed:
request_context_getter_. We need an URLRequestContext!
Backtrace:
	base::debug::StackTrace::StackTrace() [0xf3593398]
	logging::LogMessage::~LogMessage() [0xf35b28b1]
	URLFetcher::Core::Start() [0xf412b4d9]
	URLFetcher::Start() [0xf412e3c2]
	TranslateManager::FetchLanguageListFromTranslateServer() [0xf2c1df8f]
	BrowserMain() [0xf2782c0e]
	(anonymous namespace)::RunNamedProcessTypeMain() [0xf26db5f0]
	ChromeMain [0xf26dc012]
	main [0xf26dcbc9]

[Dmitry Polukhin, 2011/07/18 09:06:12]

This line is not guilty. But CL that broke Chrome is right. I reverted it
locally and Chrome is able to show login screen.  

[willchan no longer on Chromium, 2011/07/18 10:20:32]

I had encountered that stacktrace earlier in the ChromeOS tests and fixed it by
adding this line. Are you sure you are running a build that includes r92804? I'm
surprised that I could encounter this stacktrace on the bots, fix it, but that
you would still see it. Maybe there's different behavior in the build that's not
covered in tests?

         translate_manager->FetchLanguageListFromTranslateServer(user_prefs);
+      }
 
       RunUIMessageLoop(browser_process.get());
     }
   }
 
 #if defined(OS_WIN)
   // If it's the first run, log the search engine chosen.  We wait until
   // shutdown because otherwise we can't be sure the user has finished
   // selecting a search engine through the dialog reached from the first run
   // bubble link.
@@ skipping 61 matching lines @@
 #if defined(OS_CHROMEOS)
   // To be precise, logout (browser shutdown) is not yet done, but the
   // remaining work is negligible, hence we say LogoutDone here.
   chromeos::BootTimesLoader::Get()->AddLogoutTimeMarker("LogoutDone",
                                                         false);
   chromeos::BootTimesLoader::Get()->WriteLogoutTimes();
 #endif
   TRACE_EVENT_END_ETW("BrowserMain", 0, 0);
   return result_code;
 }