Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 7282034: Fix shell build on Solaris and cleanup Solaris SignalSender Run() (Closed)

Created:
9 years, 5 months ago by Robert.Mustacchi
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fixes the build for the shell on illumos and Solaris. -D__C99FEATURES__ was added to mirror how the build is done on the normal platform. The changes in the platform code are a follow up to a prior review and has the Solaris implementation be more similar to the Linux version as opposed to the FreeBSD. Contributed by Robert Mustacchi <rm@fingolfin.org>; TEST=Note the test suite uncovered a bug in libm where pow(3M) was not doing the right thing on edge cases. The only test failures are related to this bug. Committed: http://code.google.com/p/v8/source/detail?r=8502

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -26 lines) Patch
M SConstruct View 1 chunk +3 lines, -0 lines 0 comments Download
M src/platform-solaris.cc View 5 chunks +36 lines, -26 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Robert.Mustacchi_gmail.com
9 years, 5 months ago (2011-06-30 23:23:04 UTC) #1
Mads Ager (chromium)
9 years, 5 months ago (2011-07-01 05:47:17 UTC) #2
LGTM, thanks for bringing the solaris platform online again. :-)

I'll land.

Powered by Google App Engine
This is Rietveld 408576698