Move backoff_delay_ to the inner Core class.

content/common/url_fetcher.h

Index: content/common/url_fetcher.h
===================================================================
--- content/common/url_fetcher.h	(revision 91118)
+++ content/common/url_fetcher.h	(working copy)
@@ -46,7 +46,7 @@
 //
 // Then, optionally set properties on this object, like the request context or
 // extra headers:
-//   fetcher->SetExtraRequestHeaders("X-Foo: bar");
+//   fetcher->set_extra_request_headers("X-Foo: bar");
 //
 // Finally, start the request:
 //   fetcher->Start();
@@ -193,14 +193,11 @@
 
   // Returns the back-off delay before the request will be retried,
   // when a 5xx response was received.
-  base::TimeDelta backoff_delay() const { return backoff_delay_; }
+  base::TimeDelta backoff_delay() const;
 
   // Sets the back-off delay, allowing to mock 5xx requests in unit-tests.
-#if defined(UNIT_TEST)
-  void set_backoff_delay(base::TimeDelta backoff_delay) {
-    backoff_delay_ = backoff_delay;
-  }
-#endif  // defined(UNIT_TEST)
+  // Intended for testing.
+  void set_backoff_delay(base::TimeDelta backoff_delay);

[willchan no longer on Chromium, 2011/06/30 15:50:24]

joi@, Who's still using this? It looks a bit useless to me now. I think this was
relevant back when URLFetcher told its user when to call it again. But now that
retries are done internally, it is useless.

[wtc, 2011/06/30 21:36:02]

set_backoff_delay() is only used by
chrome/browser/autofill/autofill_download_unittest.cc.

chrome/browser/autofill/autofill_download.cc uses
backoff_delay() to calculate the next request time.
Note that it does
  fetcher->set_automatically_retry_on_5xx(false);
Perhaps that's why it needs to schedule its retry?

 
   // By default, the response is saved in a string. Call this method to save the
   // response to a temporary file instead. Must be called before Start().
@@ -306,9 +303,6 @@
 
   static Factory* factory_;
 
-  // Back-off time delay. 0 by default.
-  base::TimeDelta backoff_delay_;
-
   static bool g_interception_enabled;
 
   DISALLOW_COPY_AND_ASSIGN(URLFetcher);