Move backoff_delay_ to the inner Core class.

content/common/url_fetcher.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains URLFetcher, a wrapper around net::URLRequest that handles
 // low-level details like thread safety, ref counting, and incremental buffer
 // reading.  This is useful for callers who simply want to get the data from a
 // URL and don't care about all the nitty-gritty details.
 //
 // NOTE(willchan): Only one "IO" thread is supported for URLFetcher.  This is a
@@ skipping 28 matching lines @@
 typedef std::vector<std::string> ResponseCookies;
 }  // namespace net
 
 // To use this class, create an instance with the desired URL and a pointer to
 // the object to be notified when the URL has been loaded:
 //   URLFetcher* fetcher = new URLFetcher("http://www.google.com",
 //                                        URLFetcher::GET, this);
 //
 // Then, optionally set properties on this object, like the request context or
 // extra headers:
-//   fetcher->SetExtraRequestHeaders("X-Foo: bar");
+//   fetcher->set_extra_request_headers("X-Foo: bar");
 //
 // Finally, start the request:
 //   fetcher->Start();
 //
 //
 // The object you supply as a delegate must inherit from URLFetcher::Delegate;
 // when the fetch is completed, OnURLFetchComplete() will be called with a
 // pointer to the URLFetcher.  From that point until the original URLFetcher
 // instance is destroyed, you may use accessor methods to see the result of
 // the fetch. You should copy these objects if you need them to live longer
@@ skipping 126 matching lines @@
   // if it is true URLFetcher will automatically re-execute the request,
   // after backoff_delay() elapses. URLFetcher has it set to true by default.
   void set_automatically_retry_on_5xx(bool retry);
 
   int max_retries() const;
 
   void set_max_retries(int max_retries);
 
   // Returns the back-off delay before the request will be retried,
   // when a 5xx response was received.
-  base::TimeDelta backoff_delay() const { return backoff_delay_; }
+  base::TimeDelta backoff_delay() const;
 
   // Sets the back-off delay, allowing to mock 5xx requests in unit-tests.
-#if defined(UNIT_TEST)
-  void set_backoff_delay(base::TimeDelta backoff_delay) {
-    backoff_delay_ = backoff_delay;
-  }
-#endif  // defined(UNIT_TEST)
+  // Intended for testing.
+  void set_backoff_delay(base::TimeDelta backoff_delay);

[willchan no longer on Chromium, 2011/06/30 15:50:24]

joi@, Who's still using this? It looks a bit useless to me now. I think this was
relevant back when URLFetcher told its user when to call it again. But now that
retries are done internally, it is useless.

[wtc, 2011/06/30 21:36:02]

set_backoff_delay() is only used by
chrome/browser/autofill/autofill_download_unittest.cc.

chrome/browser/autofill/autofill_download.cc uses
backoff_delay() to calculate the next request time.
Note that it does
  fetcher->set_automatically_retry_on_5xx(false);
Perhaps that's why it needs to schedule its retry?

 
   // By default, the response is saved in a string. Call this method to save the
   // response to a temporary file instead. Must be called before Start().
   // |file_message_loop_proxy| will be used for all file operations.
   void SaveResponseToTemporaryFile(
       scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy);
 
   // Retrieve the response headers from the request.  Must only be called after
   // the OnURLFetchComplete callback has run.
   virtual net::HttpResponseHeaders* response_headers() const;
@@ skipping 85 matching lines @@
 
   // Only used by URLFetcherTest, returns the number of URLFetcher::Core objects
   // actively running.
   static int GetNumFetcherCores();
 
   class Core;
   scoped_refptr<Core> core_;
 
   static Factory* factory_;
 
-  // Back-off time delay. 0 by default.
-  base::TimeDelta backoff_delay_;
-
   static bool g_interception_enabled;
 
   DISALLOW_COPY_AND_ASSIGN(URLFetcher);
 };
 
 #endif  // CONTENT_COMMON_NET_URL_FETCHER_H_