Move backoff_delay_ to the inner Core class.

Move backoff_delay_ to the inner Core class so that core_ is
the only data member.

Fix typos in comments.  Add wtc@chromium.org to OWNERS.

R=joi@chromium.org,willchan@chromium.org
BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105732

[Jói, 2011-06-30 15:45:30]

LGTM

[willchan no longer on Chromium, 2011-06-30 15:50:23]

http://codereview.chromium.org/7282032/diff/1/content/common/url_fetcher.cc
File content/common/url_fetcher.cc (right):

http://codereview.chromium.org/7282032/diff/1/content/common/url_fetcher.cc#n...
content/common/url_fetcher.cc:798: backoff_delay_ = backoff_delay;
It's never read, only written. How do tests use this guy?

http://codereview.chromium.org/7282032/diff/1/content/common/url_fetcher.h
File content/common/url_fetcher.h (right):

http://codereview.chromium.org/7282032/diff/1/content/common/url_fetcher.h#ne...
content/common/url_fetcher.h:200: void set_backoff_delay(base::TimeDelta
backoff_delay);
joi@, Who's still using this? It looks a bit useless to me now. I think this was
relevant back when URLFetcher told its user when to call it again. But now that
retries are done internally, it is useless.

[wtc, 2011-06-30 21:36:02]

willchan: I answered your questions below.

http://codereview.chromium.org/7282032/diff/1/content/common/url_fetcher.cc
File content/common/url_fetcher.cc (right):

http://codereview.chromium.org/7282032/diff/1/content/common/url_fetcher.cc#n...
content/common/url_fetcher.cc:798: backoff_delay_ = backoff_delay;
It's never read in this file.  But it can be read via the
URLFetcher::backoff_delay() getter.  It is only read by
the following code (one is a test, the other is not a test):
content/common/url_fetcher_unittest.cc
chrome/browser/autofill/autofill_download.cc

http://codereview.chromium.org/7282032/diff/1/content/common/url_fetcher.h
File content/common/url_fetcher.h (right):

http://codereview.chromium.org/7282032/diff/1/content/common/url_fetcher.h#ne...
content/common/url_fetcher.h:200: void set_backoff_delay(base::TimeDelta
backoff_delay);
On 2011/06/30 15:50:24, willchan wrote:
> joi@, Who's still using this? It looks a bit useless to me now. I think this
was
> relevant back when URLFetcher told its user when to call it again. But now
that
> retries are done internally, it is useless.

set_backoff_delay() is only used by
chrome/browser/autofill/autofill_download_unittest.cc.

chrome/browser/autofill/autofill_download.cc uses
backoff_delay() to calculate the next request time.
Note that it does
  fetcher->set_automatically_retry_on_5xx(false);
Perhaps that's why it needs to schedule its retry?

[willchan no longer on Chromium, 2011-07-01 16:44:40]

LGTM

[commit-bot: I haz the power, 2011-07-01 16:59:35]

Presubmit check for 7282032-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/common/url_fetcher.h,content/common/url_fetcher.cc

[wtc, 2011-07-01 21:54:00]

darin: could you review this CL as a content/common owner?
Thanks.

[wtc, 2011-10-15 15:09:38]

willchan: please review Patch Set 3.  This is the same patch
you reviewed before, updated after the files were moved to
content/common/net, plus the addition of me to OWNERS.

joi: you don't need to review this again.

eroman: just FYI -- I'd like to be added to
content/common/net/OWNERS.

[willchan no longer on Chromium, 2011-10-15 22:34:13]

LGTM

It might be nice to assert that it's only set/read on the delegate message loop.

[commit-bot: I haz the power, 2011-10-16 13:57:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/7282032/12001

[commit-bot: I haz the power, 2011-10-16 15:08:49]

Change committed as 105732