Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Side by Side Diff: src/x64/ic-x64.cc

Issue 7282029: Fix problem with arguments object ICs not checking for dictionary mode elements. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/runtime.cc ('k') | test/mjsunit/regress/regress-1513.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1248 matching lines...) Expand 10 before | Expand all | Expand 10 after
1259 Register parameter_map, 1259 Register parameter_map,
1260 Register scratch, 1260 Register scratch,
1261 Label* slow_case) { 1261 Label* slow_case) {
1262 // Element is in arguments backing store, which is referenced by the 1262 // Element is in arguments backing store, which is referenced by the
1263 // second element of the parameter_map. The parameter_map register 1263 // second element of the parameter_map. The parameter_map register
1264 // must be loaded with the parameter map of the arguments object and is 1264 // must be loaded with the parameter map of the arguments object and is
1265 // overwritten. 1265 // overwritten.
1266 const int kBackingStoreOffset = FixedArray::kHeaderSize + kPointerSize; 1266 const int kBackingStoreOffset = FixedArray::kHeaderSize + kPointerSize;
1267 Register backing_store = parameter_map; 1267 Register backing_store = parameter_map;
1268 __ movq(backing_store, FieldOperand(parameter_map, kBackingStoreOffset)); 1268 __ movq(backing_store, FieldOperand(parameter_map, kBackingStoreOffset));
1269 Handle<Map> fixed_array_map(masm->isolate()->heap()->fixed_array_map());
1270 __ CheckMap(backing_store, fixed_array_map, slow_case, DONT_DO_SMI_CHECK);
1269 __ movq(scratch, FieldOperand(backing_store, FixedArray::kLengthOffset)); 1271 __ movq(scratch, FieldOperand(backing_store, FixedArray::kLengthOffset));
1270 __ cmpq(key, scratch); 1272 __ cmpq(key, scratch);
1271 __ j(greater_equal, slow_case); 1273 __ j(greater_equal, slow_case);
1272 __ SmiToInteger64(scratch, key); 1274 __ SmiToInteger64(scratch, key);
1273 return FieldOperand(backing_store, 1275 return FieldOperand(backing_store,
1274 scratch, 1276 scratch,
1275 times_pointer_size, 1277 times_pointer_size,
1276 FixedArray::kHeaderSize); 1278 FixedArray::kHeaderSize);
1277 } 1279 }
1278 1280
(...skipping 485 matching lines...) Expand 10 before | Expand all | Expand 10 after
1764 Condition cc = *jmp_address == Assembler::kJncShortOpcode 1766 Condition cc = *jmp_address == Assembler::kJncShortOpcode
1765 ? not_zero 1767 ? not_zero
1766 : zero; 1768 : zero;
1767 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1769 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1768 } 1770 }
1769 1771
1770 1772
1771 } } // namespace v8::internal 1773 } } // namespace v8::internal
1772 1774
1773 #endif // V8_TARGET_ARCH_X64 1775 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/runtime.cc ('k') | test/mjsunit/regress/regress-1513.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698