Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 7282019: Adjust for new NaCl startup ABI (Closed)

Created:
9 years, 5 months ago by Roland McGrath
Modified:
9 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-glibc.git@master
Visibility:
Public.

Description

Adjust for new NaCl startup ABI This replaces the startup code for applications (crt1.o) and the dynamic linker startup and glue code with versions adapted to the new NaCl startup ABI. This uses the normal C function-call ABI to start the e_entry address as a function of one argument, that being an information block holding the arguments, environment, etc. This is to enable http://codereview.chromium.org/7276050/, which see. BUG=http://code.google.com/p/nativeclient/issues/detail?id=1131 TEST=manually tested, bots can't test because of staging issues R=pasko@google.com,eaeltsin@google.com,mseaborn@google.com Committed: http://git.chromium.org/gitweb?p=native_client/nacl-glibc.git;a=commit;h=8be6943

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -193 lines) Patch
M elf/Makefile View 1 chunk +1 line, -2 lines 0 comments Download
M elf/rtld.c View 2 chunks +25 lines, -29 lines 0 comments Download
M make_sysd_rules.py View 1 chunk +1 line, -0 lines 1 comment Download
M sysdeps/i386/dl-machine.h View 2 chunks +21 lines, -0 lines 0 comments Download
M sysdeps/nacl/Makefile View 1 chunk +2 lines, -0 lines 0 comments Download
A sysdeps/nacl/dl-sysdep.c View 1 chunk +16 lines, -0 lines 0 comments Download
M sysdeps/nacl/receive_args.h View 1 chunk +2 lines, -20 lines 0 comments Download
M sysdeps/nacl/receive_args.c View 5 chunks +98 lines, -126 lines 0 comments Download
A sysdeps/nacl/start.c View 1 chunk +45 lines, -0 lines 0 comments Download
M sysdeps/x86_64/dl-machine.h View 2 chunks +13 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Roland McGrath
9 years, 5 months ago (2011-06-29 23:03:12 UTC) #1
eaeltsin
Roland, I'm looking into this. My kind request would be to provide a document on ...
9 years, 5 months ago (2011-06-30 12:27:11 UTC) #2
eaeltsin
lgtm Please keep an eye on this and on the related TCB change until all ...
9 years, 5 months ago (2011-06-30 16:43:07 UTC) #3
Roland McGrath
https://sites.google.com/a/chromium.org/dev/nativeclient/design-documents/native-client-application-binary-interface/native-client-abi-for-application-startup
9 years, 5 months ago (2011-06-30 17:14:25 UTC) #4
Mark Seaborn
9 years, 5 months ago (2011-06-30 18:06:19 UTC) #5
http://codereview.chromium.org/7282019/diff/1/make_sysd_rules.py
File make_sysd_rules.py (right):

http://codereview.chromium.org/7282019/diff/1/make_sysd_rules.py#newcode162
make_sysd_rules.py:162: "sysdeps/nacl/start.c",
Please keep this list sorted (or at least locally sorted if people have failed
to keep it sorted overall).

Powered by Google App Engine
This is Rietveld 408576698