Misc. changes. Mostly formatting.

Misc. changes. Mostly formatting. 
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91562

[dmichael (off chromium), 2011-07-01 16:44:59]

http://codereview.chromium.org/7282015/diff/1/ppapi/c/ppb.h
File ppapi/c/ppb.h (right):

http://codereview.chromium.org/7282015/diff/1/ppapi/c/ppb.h#newcode22
ppapi/c/ppb.h:22: * <code>PPB_GetInterface pointer is passed to
missing </code> after PPB_GetInterface

http://codereview.chromium.org/7282015/diff/1/ppapi/c/ppb.h#newcode26
ppapi/c/ppb.h:26: * file for the interface, such as
<code>PP_AUDIO_INTERFACE</code> found in
PP_AUDIO_INTERFACE->PPB_AUDIO_INTERFACE

http://codereview.chromium.org/7282015/diff/1/ppapi/c/ppb.h#newcode28
ppapi/c/ppb.h:28: * <code>PPB_GRAPHICS_2D_INTERFACE in ppb_graphics_2d.h. Click
missing </code>

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_core.h
File ppapi/c/ppb_core.h (right):

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_core.h#newcode40
ppapi/c/ppb_core.h:40: * function is similar to <code>AddRefVar</code> for
resources.
Actually, we should just remove the second sentence referring to AddRefVar;
there's no such thing.  There's PPB_Var.AddRef, but I don't think it really
helps to say anything about that here.  Similarly ReleaseResource shouldn't
reference ReleaseVar.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_core.h#newcode132
ppapi/c/ppb_core.h:132: * @return A <code>PP_BOOL</code> containing
<code>PP_TRUE</code> if the
PP_BOOL->PP_Bool

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h
File ppapi/c/ppb_graphics_2d.h (right):

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:32: * The <code>PPB_Graphics2D</code> structure
represents a 2D graphics context.
I think it might be better to say something along the lines of:
"<code>PPB_Graphics2D</code> defines the interface for a 2D graphics context."
(point being, it doesn't so much represent a 2D graphics as context as it lets
you work with one)

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:36: * Create() creates a 2D graphics context. The
This line looks a bit short; you could pull some words up from the next line.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:38: * creation (call BindGraphics() on the module
instance bind the returned
I don't know, this rewording doesn't seem clearer to me than 'to do that'.  If
you leave it as-is, you left out the 'to' between 'instance' and 'bind'

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:44: * true you know that you will be painting only
opaque data to this context.
'true you' -> 'PP_TRUE if you'

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:46: * page, which will give slightly higher
performance.
You might ping dspringer about this documentation, since you're in the
neighborhood...  he disagrees with saying it will give higher performance.  It
might be better to say 'which may give' instead, but dspringer understands this
better than I do.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:52: * backing store. Incorrect values could negitively
affect future
negitively->negatively

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:81: * @param[in,out] resource The 2D Graphics
resource.
[in,out]->[in]

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:110: * <code>ReplaceContents</code> which will give
slightly higher performance.
Here's another one you should ask dspringer about, since you're in the
neighborhood...  I seem to remember him telling me that the opposite is true
(i.e., PaintImageData might be faster)

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:120: * a subset of your module) and then paint it. In
this case, you'll set the
module->module instance

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:124: * entire module. In this case, you would set the
location of your image to
module->module instance

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:176: * The new image will not be painted until you
call Flush().
Maybe put <strong>Note:</strong> here like you have elsewhere?

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:178: * Release your references to the image after a
call to this function.
I liked the previous wording better here.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:197: * Flush() flushes any enqueued paint, scroll, and
replace commands for the
for->to

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:206: * Flush() will fail.
Could you maybe leave a TODO (outside the doxygen comment) to add back in the
synchronous mode description once we have support for it?

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:209: * module's current state is actually on the
screen, this function provides a
module->module instance

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:249: * <code>PP_Error_BadResource</code> the graphics
context is invalid,
missing 'if' between '</code>' and 'the'

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_messaging.h
File ppapi/c/ppb_messaging.h (right):

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_messaging.h#newc...
ppapi/c/ppb_messaging.h:17: * by the browser and is related to sending messages
to DOM elements
maybe 'which is' instead of 'and is'?

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_messaging.h#newc...
ppapi/c/ppb_messaging.h:26: * and is related to sending messages to DOM elements
associated with a
'and is' is correct here, though.

Why did you get rid of the 'JavaScript message event listeners' part?  I think
it's more correct wording.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_url_request_info.h
File ppapi/c/ppb_url_request_info.h (right):

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_url_request_info...
ppapi/c/ppb_url_request_info.h:98: * This corresponds to a <code>PP_Bool
(<code>PP_VARTYPE_BOOL</code>;
missing closing </code> tag

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_url_request_info...
ppapi/c/ppb_url_request_info.h:172: * and handling URL requests. This API is
used in conjunction with
handling->handle

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_url_request_info...
ppapi/c/ppb_url_request_info.h:194: * @return <code>PP_TRUE if the resource is a
<code>URLRequestInfo</code>,
missing </code>

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_url_response_info.h
File ppapi/c/ppb_url_response_info.h (right):

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_url_response_inf...
ppapi/c/ppb_url_response_info.h:113: * successful, 0 if
<code>PP_URLREQUESTPROPERTY_STREAMTOFILE was not
missing </code>

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_var.h
File ppapi/c/ppb_var.h (right):

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_var.h#newcode90
ppapi/c/ppb_var.h:90: * If the module frees its reference, the string will be
freed and the pointer
module->instance

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_var.h#newcode91
ppapi/c/ppb_var.h:91: * will be to random memory.
random->arbitrary

[jond, 2011-07-01 20:31:23]

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_core.h
File ppapi/c/ppb_core.h (right):

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_core.h#newcode40
ppapi/c/ppb_core.h:40: * function is similar to <code>AddRefVar</code> for
resources.
On 2011/07/01 16:45:00, dmichael1 wrote:
> Actually, we should just remove the second sentence referring to AddRefVar;
> there's no such thing.  There's PPB_Var.AddRef, but I don't think it really
> helps to say anything about that here.  Similarly ReleaseResource shouldn't
> reference ReleaseVar.

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_core.h#newcode132
ppapi/c/ppb_core.h:132: * @return A <code>PP_BOOL</code> containing
<code>PP_TRUE</code> if the
On 2011/07/01 16:45:00, dmichael1 wrote:
> PP_BOOL->PP_Bool

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h
File ppapi/c/ppb_graphics_2d.h (right):

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:32: * The <code>PPB_Graphics2D</code> structure
represents a 2D graphics context.
On 2011/07/01 16:45:00, dmichael1 wrote:
> I think it might be better to say something along the lines of:
> "<code>PPB_Graphics2D</code> defines the interface for a 2D graphics context."
> (point being, it doesn't so much represent a 2D graphics as context as it lets
> you work with one)

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:32: * The <code>PPB_Graphics2D</code> structure
represents a 2D graphics context.
On 2011/07/01 16:45:00, dmichael1 wrote:
> I think it might be better to say something along the lines of:
> "<code>PPB_Graphics2D</code> defines the interface for a 2D graphics context."
> (point being, it doesn't so much represent a 2D graphics as context as it lets
> you work with one)

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:36: * Create() creates a 2D graphics context. The
On 2011/07/01 16:45:00, dmichael1 wrote:
> This line looks a bit short; you could pull some words up from the next line.

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:38: * creation (call BindGraphics() on the module
instance bind the returned
On 2011/07/01 16:45:00, dmichael1 wrote:
> I don't know, this rewording doesn't seem clearer to me than 'to do that'.  If
> you leave it as-is, you left out the 'to' between 'instance' and 'bind'

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:44: * true you know that you will be painting only
opaque data to this context.
On 2011/07/01 16:45:00, dmichael1 wrote:
> 'true you' -> 'PP_TRUE if you'

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:46: * page, which will give slightly higher
performance.
On 2011/07/01 16:45:00, dmichael1 wrote:
> You might ping dspringer about this documentation, since you're in the
> neighborhood...  he disagrees with saying it will give higher performance.  It
> might be better to say 'which may give' instead, but dspringer understands
this
> better than I do.

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:52: * backing store. Incorrect values could negitively
affect future
On 2011/07/01 16:45:00, dmichael1 wrote:
> negitively->negatively

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:81: * @param[in,out] resource The 2D Graphics
resource.
On 2011/07/01 16:45:00, dmichael1 wrote:
> [in,out]->[in]

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:110: * <code>ReplaceContents</code> which will give
slightly higher performance.
I stole the text from the C++ graphics_2d.h file that dave reviewed recently. 

On 2011/07/01 16:45:00, dmichael1 wrote:
> Here's another one you should ask dspringer about, since you're in the
> neighborhood...  I seem to remember him telling me that the opposite is true
> (i.e., PaintImageData might be faster)

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:120: * a subset of your module) and then paint it. In
this case, you'll set the
On 2011/07/01 16:45:00, dmichael1 wrote:
> module->module instance

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:124: * entire module. In this case, you would set the
location of your image to
On 2011/07/01 16:45:00, dmichael1 wrote:
> module->module instance

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:176: * The new image will not be painted until you
call Flush().
On 2011/07/01 16:45:00, dmichael1 wrote:
> Maybe put <strong>Note:</strong> here like you have elsewhere?

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:178: * Release your references to the image after a
call to this function.
Done

On 2011/07/01 16:45:00, dmichael1 wrote:
> I liked the previous wording better here.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:197: * Flush() flushes any enqueued paint, scroll, and
replace commands for the
On 2011/07/01 16:45:00, dmichael1 wrote:
> for->to

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:206: * Flush() will fail.
On 2011/07/01 16:45:00, dmichael1 wrote:
> Could you maybe leave a TODO (outside the doxygen comment) to add back in the
> synchronous mode description once we have support for it?

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:206: * Flush() will fail.
On 2011/07/01 16:45:00, dmichael1 wrote:
> Could you maybe leave a TODO (outside the doxygen comment) to add back in the
> synchronous mode description once we have support for it?

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:209: * module's current state is actually on the
screen, this function provides a
On 2011/07/01 16:45:00, dmichael1 wrote:
> module->module instance

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_graphics_2d.h#ne...
ppapi/c/ppb_graphics_2d.h:249: * <code>PP_Error_BadResource</code> the graphics
context is invalid,
On 2011/07/01 16:45:00, dmichael1 wrote:
> missing 'if' between '</code>' and 'the'

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_messaging.h
File ppapi/c/ppb_messaging.h (right):

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_messaging.h#newc...
ppapi/c/ppb_messaging.h:17: * by the browser and is related to sending messages
to DOM elements
how about "for" 

On 2011/07/01 16:45:00, dmichael1 wrote:
> maybe 'which is' instead of 'and is'?

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_messaging.h#newc...
ppapi/c/ppb_messaging.h:26: * and is related to sending messages to DOM elements
associated with a
On 2011/07/01 16:45:00, dmichael1 wrote:
> 'and is' is correct here, though.
> 
> Why did you get rid of the 'JavaScript message event listeners' part?  I think
> it's more correct wording.

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_url_request_info.h
File ppapi/c/ppb_url_request_info.h (right):

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_url_request_info...
ppapi/c/ppb_url_request_info.h:98: * This corresponds to a <code>PP_Bool
(<code>PP_VARTYPE_BOOL</code>;
On 2011/07/01 16:45:00, dmichael1 wrote:
> missing closing </code> tag

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_url_request_info...
ppapi/c/ppb_url_request_info.h:172: * and handling URL requests. This API is
used in conjunction with
On 2011/07/01 16:45:00, dmichael1 wrote:
> handling->handle

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_url_request_info...
ppapi/c/ppb_url_request_info.h:194: * @return <code>PP_TRUE if the resource is a
<code>URLRequestInfo</code>,
On 2011/07/01 16:45:00, dmichael1 wrote:
> missing </code>

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_url_request_info...
ppapi/c/ppb_url_request_info.h:194: * @return <code>PP_TRUE if the resource is a
<code>URLRequestInfo</code>,
On 2011/07/01 16:45:00, dmichael1 wrote:
> missing </code>

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_url_response_info.h
File ppapi/c/ppb_url_response_info.h (right):

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_url_response_inf...
ppapi/c/ppb_url_response_info.h:113: * successful, 0 if
<code>PP_URLREQUESTPROPERTY_STREAMTOFILE was not
On 2011/07/01 16:45:00, dmichael1 wrote:
> missing </code>

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_var.h
File ppapi/c/ppb_var.h (right):

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_var.h#newcode90
ppapi/c/ppb_var.h:90: * If the module frees its reference, the string will be
freed and the pointer
On 2011/07/01 16:45:00, dmichael1 wrote:
> module->instance

Done.

http://codereview.chromium.org/7282015/diff/7002/ppapi/c/ppb_var.h#newcode91
ppapi/c/ppb_var.h:91: * will be to random memory.
On 2011/07/01 16:45:00, dmichael1 wrote:
> random->arbitrary

Done.

[dmichael (off chromium), 2011-07-05 15:58:19]

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb.h
File ppapi/c/ppb.h (right):

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb.h#newcode22
ppapi/c/ppb.h:22: * <code>PPB_GetInterface pointer is passed to
still missing </code>

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb.h#newcode26
ppapi/c/ppb.h:26: * file for the interface, such as
<code>PP_AUDIO_INTERFACE</code> found in
PP_AUDIO_INTERFACE->PPB_AUDIO_INTERFACE

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb.h#newcode28
ppapi/c/ppb.h:28: * <code>PPB_GRAPHICS_2D_INTERFACE in ppb_graphics_2d.h. Click
still missing </code>

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb_core.h
File ppapi/c/ppb_core.h (right):

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb_core.h#newcode47
ppapi/c/ppb_core.h:47: * function is similar to <code>ReleaseVar</code> for
Resources.
Please remove the second sentence here, too.

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb_graphics_2d.h
File ppapi/c/ppb_graphics_2d.h (right):

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb_graphics_2d.h#n...
ppapi/c/ppb_graphics_2d.h:100: * offset by <code>top_left/code>.
lost the '<' for your closing </code> tag

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb_graphics_2d.h#n...
ppapi/c/ppb_graphics_2d.h:119: * bitmap representing your entire module. In this
case, you would set the
Bad merge?  The documentation seems to repeat itself here...

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb_graphics_2d.h#n...
ppapi/c/ppb_graphics_2d.h:205: * module's image is actually on the screen, this
function provides
module->instance

[jond, 2011-07-05 17:09:23]

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb.h
File ppapi/c/ppb.h (right):

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb.h#newcode22
ppapi/c/ppb.h:22: * <code>PPB_GetInterface pointer is passed to
On 2011/07/05 15:58:19, dmichael1 wrote:
> still missing </code>

Done.

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb.h#newcode22
ppapi/c/ppb.h:22: * <code>PPB_GetInterface pointer is passed to
On 2011/07/05 15:58:19, dmichael1 wrote:
> still missing </code>

Done.

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb.h#newcode26
ppapi/c/ppb.h:26: * file for the interface, such as
<code>PP_AUDIO_INTERFACE</code> found in
On 2011/07/05 15:58:19, dmichael1 wrote:
> PP_AUDIO_INTERFACE->PPB_AUDIO_INTERFACE

Done.

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb.h#newcode28
ppapi/c/ppb.h:28: * <code>PPB_GRAPHICS_2D_INTERFACE in ppb_graphics_2d.h. Click
On 2011/07/05 15:58:19, dmichael1 wrote:
> still missing </code>

Done.

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb.h#newcode28
ppapi/c/ppb.h:28: * <code>PPB_GRAPHICS_2D_INTERFACE in ppb_graphics_2d.h. Click
On 2011/07/05 15:58:19, dmichael1 wrote:
> still missing </code>

Done.

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb_core.h
File ppapi/c/ppb_core.h (right):

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb_core.h#newcode47
ppapi/c/ppb_core.h:47: * function is similar to <code>ReleaseVar</code> for
Resources.
On 2011/07/05 15:58:19, dmichael1 wrote:
> Please remove the second sentence here, too.

Done.

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb_graphics_2d.h
File ppapi/c/ppb_graphics_2d.h (right):

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb_graphics_2d.h#n...
ppapi/c/ppb_graphics_2d.h:100: * offset by <code>top_left/code>.
On 2011/07/05 15:58:19, dmichael1 wrote:
> lost the '<' for your closing </code> tag

Done.

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb_graphics_2d.h#n...
ppapi/c/ppb_graphics_2d.h:119: * bitmap representing your entire module. In this
case, you would set the
On 2011/07/05 15:58:19, dmichael1 wrote:
> Bad merge?  The documentation seems to repeat itself here...

Done.

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb_graphics_2d.h#n...
ppapi/c/ppb_graphics_2d.h:119: * bitmap representing your entire module. In this
case, you would set the
On 2011/07/05 15:58:19, dmichael1 wrote:
> Bad merge?  The documentation seems to repeat itself here...

Done.

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb_graphics_2d.h#n...
ppapi/c/ppb_graphics_2d.h:205: * module's image is actually on the screen, this
function provides
On 2011/07/05 15:58:19, dmichael1 wrote:
> module->instance

Done.

http://codereview.chromium.org/7282015/diff/10001/ppapi/c/ppb_graphics_2d.h#n...
ppapi/c/ppb_graphics_2d.h:205: * module's image is actually on the screen, this
function provides
On 2011/07/05 15:58:19, dmichael1 wrote:
> module->instance

Done.

[dmichael (off chromium), 2011-07-05 17:25:38]

2 last nits, o/w LGTM

http://codereview.chromium.org/7282015/diff/16001/ppapi/c/ppb_graphics_2d.h
File ppapi/c/ppb_graphics_2d.h (right):

http://codereview.chromium.org/7282015/diff/16001/ppapi/c/ppb_graphics_2d.h#n...
ppapi/c/ppb_graphics_2d.h:100: * offset by <code>top_left/code>.
Nice catch below, but it's still missing on line 100

http://codereview.chromium.org/7282015/diff/16001/ppapi/c/ppb_graphics_2d.h#n...
ppapi/c/ppb_graphics_2d.h:117: * bitmap representing your entire module. In this
case, you would set the
module->instance

[jond, 2011-07-05 17:30:31]

http://codereview.chromium.org/7282015/diff/16001/ppapi/c/ppb_graphics_2d.h
File ppapi/c/ppb_graphics_2d.h (right):

http://codereview.chromium.org/7282015/diff/16001/ppapi/c/ppb_graphics_2d.h#n...
ppapi/c/ppb_graphics_2d.h:100: * offset by <code>top_left/code>.
On 2011/07/05 17:25:38, dmichael1 wrote:
> Nice catch below, but it's still missing on line 100

Done.

http://codereview.chromium.org/7282015/diff/16001/ppapi/c/ppb_graphics_2d.h#n...
ppapi/c/ppb_graphics_2d.h:117: * bitmap representing your entire module. In this
case, you would set the
On 2011/07/05 17:25:38, dmichael1 wrote:
> module->instance

Done.

[dmichael (off chromium), 2011-07-06 17:51:04]

LGTM, in case you were waiting for me to say it again :-)