switch from sample shell to d8 for unit test

switch from sample shell to d8 for unit test

[Yang, 2011-06-29 14:07:34]

Hi Rico,

I just prepared to switch from sample shell to d8. I changed the files for
tools/test.py to use d8 by default. However, Mads told me that there are a few
more things to be changed, of which you know best.

There is a new command line option for d8: adding --test makes things go
slightly faster. This can add up especially for the slow arm simulator. It's
specially designed to be used with unit testing.

Thanks,

Yang

http://codereview.chromium.org/7282008/diff/1/tools/test.py
File tools/test.py (right):

http://codereview.chromium.org/7282008/diff/1/tools/test.py#newcode1275
tools/test.py:1275: if options.shell == "d8":
adding --test as command line option makes things go slightly faster, but only
suitable when using d8 for unit tests like here.

[Vitaly Repeshko, 2011-06-29 16:14:03]

Is it going to support --isolates? It'd be nice to it from shell to d8.


-- Vitaly

[Rico, 2011-06-30 07:33:33]

As vitaly mentions, we need support for the --isolates flag (otherwise our
isolates builder will become red)
When that is fixed, LGTM ( I have already committed
http://codereview.chromium.org/7218071/ so the buildbot is ready for a restart
when this has landed)

[Yang, 2011-06-30 09:41:58]

Vitaly or Rico,

dropping me a line on how to use the sample shell with --isolate would help me a
lot, better yet, a test case. I'm currently porting that part of the code to d8.

Thanks!

Yang

On 2011/06/30 07:33:33, Rico wrote:
> As vitaly mentions, we need support for the --isolates flag (otherwise our
> isolates builder will become red)
> When that is fixed, LGTM ( I have already committed
> http://codereview.chromium.org/7218071/ so the buildbot is ready for a restart
> when this has landed)

[Yang, 2011-07-07 16:17:01]

I just finished porting --isolate to d8, still waiting for code review though.
In the meantime: can you think of any features that exist in the sample shell,
but not in d8?

On 2011/06/30 09:41:58, yangguo wrote:
> Vitaly or Rico,
> 
> dropping me a line on how to use the sample shell with --isolate would help me
a
> lot, better yet, a test case. I'm currently porting that part of the code to
d8.
> 
> Thanks!
> 
> Yang
> 
> On 2011/06/30 07:33:33, Rico wrote:
> > As vitaly mentions, we need support for the --isolates flag (otherwise our
> > isolates builder will become red)
> > When that is fixed, LGTM ( I have already committed
> > http://codereview.chromium.org/7218071/ so the buildbot is ready for a
restart
> > when this has landed)