src/type-info.cc - Issue 7282007: Using KeyedStoreIC_Generic_Strict must prevent polymorphic case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/type-info.cc

Issue 7282007: Using KeyedStoreIC_Generic_Strict must prevent polymorphic case. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/type-info.cc

diff --git a/src/type-info.cc b/src/type-info.cc

index 4c34ff8fb33945d58e5d5743db9a0c3e4d817853..defb1ae9666a48da8f41cc83eb7f5e028354da01 100644

--- a/src/type-info.cc

+++ b/src/type-info.cc

@@ -122,6 +122,7 @@ bool TypeFeedbackOracle::StoreIsMegamorphicWithTypeInfo(Expression* expr) {

Builtins* builtins = Isolate::Current()->builtins();

return code->is_keyed_store_stub() &&

*code != builtins->builtin(Builtins::kKeyedStoreIC_Generic) &&

+ *code != builtins->builtin(Builtins::kKeyedStoreIC_Generic_Strict) &&

code->ic_state() == MEGAMORPHIC;

}

return false;

« no previous file with comments | « no previous file | no next file » | no next file with comments »