Fixes DomView selection problems.

Fixes DomView selection problems.

BUG=chromium-os:17130
TEST=open DomView based dialog (Sim,Eula, etc.), try to select.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91676

[altimofeev, 2011-06-30 12:02:36]

Brett, please take a look.

[altimofeev, 2011-07-01 04:55:05]

ping

[brettw, 2011-07-01 18:03:30]

I'm not on the OWNERS list for that directory, so you'll have to get one of them
to look at it anyway. I'd send it to Ben, Peter, or Scott instead of me.

[altimofeev, 2011-07-04 05:56:22]

PTAL

[sky, 2011-07-04 20:11:44]

http://codereview.chromium.org/7281029/diff/1001/chrome/browser/ui/views/dom_...
File chrome/browser/ui/views/dom_view.cc (right):

http://codereview.chromium.org/7281029/diff/1001/chrome/browser/ui/views/dom_...
chrome/browser/ui/views/dom_view.cc:39:
renderer_preferences_util::UpdateFromSystemSettings(
I'm not familiar with what renderer_preferences does. How come you need to
invoke this?

[altimofeev, 2011-07-05 08:41:32]

On 2011/07/04 20:11:44, sky wrote:
>
http://codereview.chromium.org/7281029/diff/1001/chrome/browser/ui/views/dom_...
> File chrome/browser/ui/views/dom_view.cc (right):
> 
>
http://codereview.chromium.org/7281029/diff/1001/chrome/browser/ui/views/dom_...
> chrome/browser/ui/views/dom_view.cc:39:
> renderer_preferences_util::UpdateFromSystemSettings(
> I'm not familiar with what renderer_preferences does. How come you need to
> invoke this?

As bug states, DomView has problems with selections. UpdateFromSystemSettings()
setups correct style to be used for the selected regions. This method is invoked
by the normal browser via TabContentsWrapper. DomView uses lightened version
(just TabContents), and it looks like it lacks UpdateFromSystemSettings() call.

[sky, 2011-07-06 14:13:40]

LGTM