Issue 7281018: net: Build net.dll on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7281018: net: Build net.dll on Windows. (Closed)

Created:
9 years, 5 months ago by rvargas (doing something else)

Modified:
9 years, 5 months ago

Reviewers:
wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

net: Build net.dll on Windows. BUG=76997 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91360

Patch Set 5 : '' #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -4 lines)			Patch
M	jingle/jingle.gyp	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/net.gyp	View	1	4 chunks	+21 lines, -3 lines	0 comments	Download
M	net/socket/client_socket_pool_base.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/remoting.gyp	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. http://codereview.chromium.org/7281018/diff/1/net/net.gyp File net/net.gyp (right): http://codereview.chromium.org/7281018/diff/1/net/net.gyp#newcode824 net/net.gyp:824: 4251, Would be nice to add a comment ...

9 years, 5 months ago (2011-06-29 23:15:50 UTC) #2

rvargas (doing something else)

Thanks. http://codereview.chromium.org/7281018/diff/1/net/net.gyp File net/net.gyp (right): http://codereview.chromium.org/7281018/diff/1/net/net.gyp#newcode824 net/net.gyp:824: 4251, On 2011/06/29 23:15:50, wtc wrote: > Would ...

9 years, 5 months ago (2011-06-30 00:22:13 UTC) #3

rvargas (doing something else)

There are a bunch of chromoting targets that are not part of chrome.sln so I ...

9 years, 5 months ago (2011-06-30 01:16:04 UTC) #4

LGTM.

Expand Messages | Collapse Messages

Issue 7281018: net: Build net.dll on Windows. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Messages