Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: chrome/browser/sync/glue/sync_backend_host.cc

Issue 7281017: [Sync] Add RequestCleanupDisabledTypes() method to SyncManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Replaced with TODOs Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/glue/sync_backend_host.h ('k') | chrome/browser/sync/test_profile_sync_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/glue/sync_backend_host.cc
diff --git a/chrome/browser/sync/glue/sync_backend_host.cc b/chrome/browser/sync/glue/sync_backend_host.cc
index 9dc44f54ffc070847dcb41ebb2a0620b0c47f2d4..a6883c9d92f7001189e4677f2d854fe9bb1d28c0 100644
--- a/chrome/browser/sync/glue/sync_backend_host.cc
+++ b/chrome/browser/sync/glue/sync_backend_host.cc
@@ -388,7 +388,7 @@ void SyncBackendHost::FinishConfigureDataTypesOnFrontendLoop() {
if (pending_config_mode_state_->deleted_type) {
sync_thread_.message_loop()->PostTask(FROM_HERE,
NewRunnableMethod(core_.get(),
- &SyncBackendHost::Core::DeferNudgeForCleanup));
+ &SyncBackendHost::Core::DeferCleanup));
}
if (pending_config_mode_state_->added_types.none() &&
@@ -447,12 +447,6 @@ syncable::ModelTypeSet SyncBackendHost::GetEncryptedDataTypes() const {
return core_->sync_manager()->GetEncryptedDataTypes();
}
-void SyncBackendHost::RequestNudge(const tracked_objects::Location& location) {
- sync_thread_.message_loop()->PostTask(FROM_HERE,
- NewRunnableMethod(core_.get(), &SyncBackendHost::Core::DoRequestNudge,
- location));
-}
-
void SyncBackendHost::ActivateDataType(
DataTypeController* data_type_controller,
ChangeProcessor* change_processor) {
@@ -638,7 +632,7 @@ SyncBackendHost::Core::Core(const std::string& name, SyncBackendHost* backend)
sync_manager_observer_(ALLOW_THIS_IN_INITIALIZER_LIST(this)),
parent_router_(NULL),
processing_passphrase_(false),
- deferred_nudge_for_cleanup_requested_(false) {
+ deferred_cleanup_requested_(false) {
}
// Helper to construct a user agent string (ASCII) suitable for use by
@@ -718,9 +712,9 @@ void SyncBackendHost::Core::DoUpdateEnabledTypes() {
void SyncBackendHost::Core::DoStartSyncing() {
DCHECK(MessageLoop::current() == host_->sync_thread_.message_loop());
sync_manager_->StartSyncingNormally();
- if (deferred_nudge_for_cleanup_requested_)
- sync_manager_->RequestNudge(FROM_HERE);
- deferred_nudge_for_cleanup_requested_ = false;
+ if (deferred_cleanup_requested_)
+ sync_manager_->RequestCleanupDisabledTypes();
+ deferred_cleanup_requested_ = false;
}
void SyncBackendHost::Core::DoSetPassphrase(const std::string& passphrase,
@@ -1080,11 +1074,6 @@ void SyncBackendHost::Core::StartSavingChanges() {
this, &Core::SaveChanges);
}
-void SyncBackendHost::Core::DoRequestNudge(
- const tracked_objects::Location& nudge_location) {
- sync_manager_->RequestNudge(nudge_location);
-}
-
void SyncBackendHost::Core::DoRequestClearServerData() {
sync_manager_->RequestClearServerData();
}
@@ -1164,9 +1153,9 @@ void SyncBackendHost::Core::DoProcessMessage(
sync_manager_->GetJsBackend()->ProcessMessage(name, args, sender);
}
-void SyncBackendHost::Core::DeferNudgeForCleanup() {
+void SyncBackendHost::Core::DeferCleanup() {
DCHECK_EQ(MessageLoop::current(), host_->sync_thread_.message_loop());
- deferred_nudge_for_cleanup_requested_ = true;
+ deferred_cleanup_requested_ = true;
}
} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/glue/sync_backend_host.h ('k') | chrome/browser/sync/test_profile_sync_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698