[Sync] Add RequestCleanupDisabledTypes() method to SyncManager

chrome/browser/sync/engine/sync_scheduler.h

Index: chrome/browser/sync/engine/sync_scheduler.h
diff --git a/chrome/browser/sync/engine/sync_scheduler.h b/chrome/browser/sync/engine/sync_scheduler.h
index 94769aefe51adda7b07ea150a225565cc11a48fe..66353b3127f1a5c9ac8ce25ea4679017772eae14 100644
--- a/chrome/browser/sync/engine/sync_scheduler.h
+++ b/chrome/browser/sync/engine/sync_scheduler.h
@@ -93,6 +93,7 @@ class SyncScheduler : public sessions::SyncSession::Delegate,
   void ScheduleConfig(const syncable::ModelTypeBitSet& types,
       sync_api::ConfigureReason reason);
   void ScheduleClearUserData();
+  void ScheduleCleanupDisabledTypes();
 
   // Change status of notifications in the SyncSessionContext.
   void set_notifications_enabled(bool notifications_enabled);
@@ -284,6 +285,9 @@ class SyncScheduler : public sessions::SyncSession::Delegate,
   // Coalesces the current job with the pending nudge.
   void InitOrCoalescePendingJob(const SyncSessionJob& job);
 
+  // Cleans up disabled types separately from a sync cycle.
+  void CleanupDisabledTypes();

[tim (not reviewing), 2011/07/28 01:42:23]

So, I get why this is here, but it confuses me to have two separate ways to do
this. Since the canonical way the syncer works is via its internal state
machine, maybe we should be thinking about this that way.  E.g. I just realized
a better way to do what I tried to do before (pulling SyncerEndCommand out of
the cycle) would have been to simply add a condition in case APPLY_UPDATES:,
around the assignment to next_state, to consider the end_state.  If end_state ==
APPLY_UPDATES then next_state = SYNCER_END.

I think that solves all the world's problems?

[akalin, 2011/07/28 02:45:51]

Done.  Let's see if that works.

+
   // 'Impl' here refers to real implementation of public functions, running on
   // |thread_|.
   void StartImpl(Mode mode, ModeChangeCallback* callback);