Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 7281015: Add sql/sql.gyp to start building libsql and sql_unittests. (Closed)

Created:
9 years, 5 months ago by Robert Sesek
Modified:
9 years, 5 months ago
CC:
chromium-reviews, Scott Hess - ex-Googler, tfarina
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add sql/sql.gyp to start building libsql and sql_unittests. Nothing uses this yet, but is needed to make the changes to buildbot. It only hooks into all.gyp so it can be built. BUG=72317 TEST=sql_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91132

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
M build/all.gyp View 8 chunks +8 lines, -0 lines 0 comments Download
A sql/sql.gyp View 1 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
9 years, 5 months ago (2011-06-29 23:07:15 UTC) #1
Mark Mentovai
http://codereview.chromium.org/7281015/diff/1/sql/sql.gyp File sql/sql.gyp (right): http://codereview.chromium.org/7281015/diff/1/sql/sql.gyp#newcode18 sql/sql.gyp:18: 'export_dependent_settings': [ Really? What do you need to export?
9 years, 5 months ago (2011-06-29 23:09:29 UTC) #2
Robert Sesek
http://codereview.chromium.org/7281015/diff/1/sql/sql.gyp File sql/sql.gyp (right): http://codereview.chromium.org/7281015/diff/1/sql/sql.gyp#newcode18 sql/sql.gyp:18: 'export_dependent_settings': [ On 2011/06/29 23:09:29, Mark Mentovai wrote: > ...
9 years, 5 months ago (2011-06-29 23:36:21 UTC) #3
Mark Mentovai
9 years, 5 months ago (2011-06-30 00:06:55 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698