Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 7280019: Fixes bug where clicks on 'ok' button in about dialog wouldn't (Closed)

Created:
9 years, 5 months ago by sky
Modified:
9 years, 5 months ago
Reviewers:
Finnur
CC:
chromium-reviews
Visibility:
Public.

Description

Fixes bug where clicks on 'ok' button in about dialog wouldn't work. This was happening because one of the labels was extending into the ok button and since the ok button is no longer a native button it only gets events if another view is not on top of it. BUG=87439 74724 TEST=see bug R=finnur@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91139

Patch Set 1 #

Patch Set 2 : Truncate instead of extending into buttons #

Total comments: 2

Patch Set 3 : Remove unneeded field #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M chrome/browser/ui/views/about_chrome_view.cc View 1 2 2 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
9 years, 5 months ago (2011-06-29 22:51:43 UTC) #1
sky
GAH! This isn't going to be good enough. See 87967. Let me cook up something ...
9 years, 5 months ago (2011-06-29 22:53:50 UTC) #2
sky
Ok, I think I got it. The label is now properly truncated if too big. ...
9 years, 5 months ago (2011-06-29 23:30:25 UTC) #3
Finnur
LGTM, one nit: http://codereview.chromium.org/7280019/diff/1003/chrome/browser/ui/views/about_chrome_view.cc File chrome/browser/ui/views/about_chrome_view.cc (right): http://codereview.chromium.org/7280019/diff/1003/chrome/browser/ui/views/about_chrome_view.cc#newcode411 chrome/browser/ui/views/about_chrome_view.cc:411: int max_update_width = sz.width() - update_label_x; ...
9 years, 5 months ago (2011-06-29 23:38:00 UTC) #4
sky
9 years, 5 months ago (2011-06-29 23:41:36 UTC) #5
http://codereview.chromium.org/7280019/diff/1003/chrome/browser/ui/views/abou...
File chrome/browser/ui/views/about_chrome_view.cc (right):

http://codereview.chromium.org/7280019/diff/1003/chrome/browser/ui/views/abou...
chrome/browser/ui/views/about_chrome_view.cc:411: int max_update_width =
sz.width() - update_label_x;
On 2011/06/29 23:38:00, Finnur wrote:
> this is redundant, no?

You are absolutely right. Fixed.

Powered by Google App Engine
This is Rietveld 408576698