Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 7280005: Simplify the way we call UnaryOpStubs, saving one unused no-op after the call itself. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3656 matching lines...) Expand 10 before | Expand all | Expand 10 after
3667 // TODO(svenpanne): Allowing format strings in Comment would be nice here... 3667 // TODO(svenpanne): Allowing format strings in Comment would be nice here...
3668 Comment cmt(masm_, comment); 3668 Comment cmt(masm_, comment);
3669 bool can_overwrite = expr->expression()->ResultOverwriteAllowed(); 3669 bool can_overwrite = expr->expression()->ResultOverwriteAllowed();
3670 UnaryOverwriteMode overwrite = 3670 UnaryOverwriteMode overwrite =
3671 can_overwrite ? UNARY_OVERWRITE : UNARY_NO_OVERWRITE; 3671 can_overwrite ? UNARY_OVERWRITE : UNARY_NO_OVERWRITE;
3672 UnaryOpStub stub(expr->op(), overwrite); 3672 UnaryOpStub stub(expr->op(), overwrite);
3673 // UnaryOpStub expects the argument to be in the 3673 // UnaryOpStub expects the argument to be in the
3674 // accumulator register rax. 3674 // accumulator register rax.
3675 VisitForAccumulatorValue(expr->expression()); 3675 VisitForAccumulatorValue(expr->expression());
3676 SetSourcePosition(expr->position()); 3676 SetSourcePosition(expr->position());
3677 EmitCallIC(stub.GetCode(), NULL, expr->id()); 3677 EmitCallIC(stub.GetCode(), RelocInfo::CODE_TARGET, expr->id());
3678 context()->Plug(rax); 3678 context()->Plug(rax);
3679 } 3679 }
3680 3680
3681 3681
3682 void FullCodeGenerator::VisitCountOperation(CountOperation* expr) { 3682 void FullCodeGenerator::VisitCountOperation(CountOperation* expr) {
3683 Comment cmnt(masm_, "[ CountOperation"); 3683 Comment cmnt(masm_, "[ CountOperation");
3684 SetSourcePosition(expr->position()); 3684 SetSourcePosition(expr->position());
3685 3685
3686 // Invalid left-hand-sides are rewritten to have a 'throw 3686 // Invalid left-hand-sides are rewritten to have a 'throw
3687 // ReferenceError' as the left-hand side. 3687 // ReferenceError' as the left-hand side.
(...skipping 554 matching lines...) Expand 10 before | Expand all | Expand 10 after
4242 __ ret(0); 4242 __ ret(0);
4243 } 4243 }
4244 4244
4245 4245
4246 #undef __ 4246 #undef __
4247 4247
4248 4248
4249 } } // namespace v8::internal 4249 } } // namespace v8::internal
4250 4250
4251 #endif // V8_TARGET_ARCH_X64 4251 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698