Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 7280005: Simplify the way we call UnaryOpStubs, saving one unused no-op after the call itself. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3724 matching lines...) Expand 10 before | Expand all | Expand 10 after
3735 // TODO(svenpanne): Allowing format strings in Comment would be nice here... 3735 // TODO(svenpanne): Allowing format strings in Comment would be nice here...
3736 Comment cmt(masm_, comment); 3736 Comment cmt(masm_, comment);
3737 bool can_overwrite = expr->expression()->ResultOverwriteAllowed(); 3737 bool can_overwrite = expr->expression()->ResultOverwriteAllowed();
3738 UnaryOverwriteMode overwrite = 3738 UnaryOverwriteMode overwrite =
3739 can_overwrite ? UNARY_OVERWRITE : UNARY_NO_OVERWRITE; 3739 can_overwrite ? UNARY_OVERWRITE : UNARY_NO_OVERWRITE;
3740 UnaryOpStub stub(expr->op(), overwrite); 3740 UnaryOpStub stub(expr->op(), overwrite);
3741 // UnaryOpStub expects the argument to be in the 3741 // UnaryOpStub expects the argument to be in the
3742 // accumulator register r0. 3742 // accumulator register r0.
3743 VisitForAccumulatorValue(expr->expression()); 3743 VisitForAccumulatorValue(expr->expression());
3744 SetSourcePosition(expr->position()); 3744 SetSourcePosition(expr->position());
3745 EmitCallIC(stub.GetCode(), NULL, expr->id()); 3745 EmitCallIC(stub.GetCode(), RelocInfo::CODE_TARGET, expr->id());
3746 context()->Plug(r0); 3746 context()->Plug(r0);
3747 } 3747 }
3748 3748
3749 3749
3750 void FullCodeGenerator::VisitCountOperation(CountOperation* expr) { 3750 void FullCodeGenerator::VisitCountOperation(CountOperation* expr) {
3751 Comment cmnt(masm_, "[ CountOperation"); 3751 Comment cmnt(masm_, "[ CountOperation");
3752 SetSourcePosition(expr->position()); 3752 SetSourcePosition(expr->position());
3753 3753
3754 // Invalid left-hand sides are rewritten to have a 'throw ReferenceError' 3754 // Invalid left-hand sides are rewritten to have a 'throw ReferenceError'
3755 // as the left-hand side. 3755 // as the left-hand side.
(...skipping 552 matching lines...) Expand 10 before | Expand all | Expand 10 after
4308 __ mov(r1, Operand(r1, ASR, 1)); // Un-smi-tag value. 4308 __ mov(r1, Operand(r1, ASR, 1)); // Un-smi-tag value.
4309 __ add(pc, r1, Operand(masm_->CodeObject())); 4309 __ add(pc, r1, Operand(masm_->CodeObject()));
4310 } 4310 }
4311 4311
4312 4312
4313 #undef __ 4313 #undef __
4314 4314
4315 } } // namespace v8::internal 4315 } } // namespace v8::internal
4316 4316
4317 #endif // V8_TARGET_ARCH_ARM 4317 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698