Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 7278039: Revert preparser duplicate detection. (Closed)

Created:
9 years, 5 months ago by Lasse Reichstein
Modified:
9 years, 5 months ago
Reviewers:
Rico
CC:
v8-dev, Jakob Kummerow
Visibility:
Public.

Description

Revert preparser duplicate detection. Doesn't work on Windows yet. Crashes some layout-tests. Committed: http://code.google.com/p/v8/source/detail?r=8542

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -611 lines) Patch
M src/SConscript View 1 chunk +0 lines, -5 lines 0 comments Download
M src/bignum-dtoa.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/conversions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/conversions.cc View 3 chunks +21 lines, -2 lines 0 comments Download
M src/dtoa.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/fast-dtoa.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/fixed-dtoa.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/preparser.h View 4 chunks +0 lines, -97 lines 0 comments Download
M src/preparser.cc View 20 chunks +33 lines, -215 lines 0 comments Download
M src/preparser-api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/scanner-base.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/utils.h View 2 chunks +10 lines, -15 lines 0 comments Download
D test/preparser/duplicate-parameter.pyt View 1 chunk +0 lines, -90 lines 0 comments Download
D test/preparser/duplicate-property.pyt View 1 chunk +0 lines, -162 lines 0 comments Download
M test/preparser/testcfg.py View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
9 years, 5 months ago (2011-07-06 09:13:40 UTC) #1
Rico
9 years, 5 months ago (2011-07-06 09:14:42 UTC) #2
Rubber-stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698