REGRESSION: Status text of download item cell should fade in/out

REGRESSION: Status text of download item cell should fade in/out


BUG=88423
TEST=manually. Download something fairly big, and confirm that the status text fades inand out inside the download shelf.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91526

[keishi1, 2011-07-05 09:41:36]

Regression seems to be caused by
http://src.chromium.org/viewvc/chrome?view=rev&revision=37676

Instead of setting the font color alpha, I set the composite mode because it is
a more generic solution.

[Randy Smith (Not in Mondays), 2011-07-05 14:49:45]

This sorta has to be reviewed by Nico--I don't have the Cocoa UI expertise, and
Asanka's on vacation this week.

[Nico, 2011-07-05 15:41:32]

> Regression seems to be caused by
> http://src.chromium.org/viewvc/chrome?view=rev&revision=37676

Good catch!

> Instead of setting the font color alpha, I set the composite mode because it
is
> a more generic solution.

I think it also disables subpixel antialiasing. Can you post a screenshot of the
secondary text (with full transparency) of the code before your patch, with your
patch, and when you do

  [secondaryColor colorWithAlphaComponent:statusAlpha_],
NSForegroundColorAttributeName,

instead?

[keishi1, 2011-07-06 03:34:04]

On 2011/07/05 15:41:32, Nico wrote:
> > Regression seems to be caused by
> > http://src.chromium.org/viewvc/chrome?view=rev&revision=37676
> 
> Good catch!
> 
> > Instead of setting the font color alpha, I set the composite mode because it
> is
> > a more generic solution.
> 
> I think it also disables subpixel antialiasing. Can you post a screenshot of
the
> secondary text (with full transparency) of the code before your patch, with
your
> patch, and when you do
> 
>   [secondaryColor colorWithAlphaComponent:statusAlpha_],
> NSForegroundColorAttributeName,
> 
> instead?

https://docs.google.com/leaf?id=0B4aiM9jljUy8ODVhNjQxY2YtY2ZjYS00MmEwLTg5N2Et...

Here is the comparison screenshot. I have max sub pixel anti aliasing turned on.

I may be wrong but my understanding is that sub pixel anti aliasing should work
unless it is a bitmap context or CALayer with transparent background.

[Nico, 2011-07-06 04:58:03]

LGTM

Thank you for bearing with my questions. For what it's worth, I prefer the patch
that changes the color since that's just one line of code instead of six, but
it's up to you.

[commit-bot: I haz the power, 2011-07-06 06:09:27]

Change committed as 91526