Issue 7277088: Fix issues in IT2Me webapp caused by r91658.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7277088: Fix issues in IT2Me webapp caused by r91658. (Closed)

Created:
9 years, 5 months ago by Sergey Ulanov

Modified:
9 years, 5 months ago

Reviewers:
commit-bot: I haz the power, awong

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix issues in IT2Me webapp caused by r91658. 1. Elemnt IDs were updated in chroice.html, but not in remoting.js 2. Plugin container must not be hidden, otherwise the plugin doesn't load. BUG=None TEST=IT2Me host works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91750

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	remoting/webapp/me2mom/choice.html	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	remoting/webapp/me2mom/remoting.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

9 years, 5 months ago (2011-07-07 20:39:55 UTC) #3

Try job failure for 7277088-1 (retry) on win for step "compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Expand Messages | Collapse Messages