Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7277010: Apply CSP to about:conflicts page. (Closed)

Created:
9 years, 6 months ago by Tom Sepez
Modified:
9 years, 5 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Apply CSP to about:conflicts page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92596

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -142 lines) Patch
M chrome/browser/browser_resources.grd View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/about_conflicts.html View 1 2 3 4 5 6 7 8 3 chunks +8 lines, -62 lines 0 comments Download
A chrome/browser/resources/about_conflicts.js View 1 chunk +59 lines, -0 lines 4 comments Download
M chrome/browser/ui/webui/conflicts_ui.cc View 1 2 3 4 5 6 7 3 chunks +29 lines, -78 lines 0 comments Download
M chrome/test/functional/special_tabs.py View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Tom Sepez
This is one I coded the other week, but never landed, because I don't own ...
9 years, 6 months ago (2011-06-27 20:05:05 UTC) #1
abarth-chromium
Looks reasonable to me, but I neither looked carefully, own this code, or have a ...
9 years, 6 months ago (2011-06-27 20:16:32 UTC) #2
Tom Sepez
at least we now have automated coverage. Let's see if this changelist kicks out the ...
9 years, 5 months ago (2011-07-01 23:28:56 UTC) #3
Tom Sepez
Verified page still renders on windows box.
9 years, 5 months ago (2011-07-11 22:10:24 UTC) #4
Tom Sepez
This is still hung up on getting the special_tabs.py test re-enabled on windows ...
9 years, 5 months ago (2011-07-12 18:06:10 UTC) #5
Tom Sepez
Ok. Pyauto tests re-enabled.
9 years, 5 months ago (2011-07-13 21:41:18 UTC) #6
Tom Sepez
Evan, PTAL.
9 years, 5 months ago (2011-07-13 22:09:57 UTC) #7
Evan Stade
lgtm http://codereview.chromium.org/7277010/diff/22001/chrome/browser/resources/about_conflicts.js File chrome/browser/resources/about_conflicts.js (right): http://codereview.chromium.org/7277010/diff/22001/chrome/browser/resources/about_conflicts.js#newcode1 chrome/browser/resources/about_conflicts.js:1: /** license header http://codereview.chromium.org/7277010/diff/22001/chrome/browser/resources/about_conflicts.js#newcode59 chrome/browser/resources/about_conflicts.js:59: extra line or ...
9 years, 5 months ago (2011-07-14 19:33:44 UTC) #8
Tom Sepez
9 years, 5 months ago (2011-07-14 19:37:54 UTC) #9 
thanks

http://codereview.chromium.org/7277010/diff/22001/chrome/browser/resources/ab...
File chrome/browser/resources/about_conflicts.js (right):

http://codereview.chromium.org/7277010/diff/22001/chrome/browser/resources/ab...
chrome/browser/resources/about_conflicts.js:1: /**
On 2011/07/14 19:33:44, Evan Stade wrote:
> license header

Done.

http://codereview.chromium.org/7277010/diff/22001/chrome/browser/resources/ab...
chrome/browser/resources/about_conflicts.js:59: 
On 2011/07/14 19:33:44, Evan Stade wrote:
> extra line or rietveld error?

Done.

Powered by Google App Engine
This is Rietveld 408576698