Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: SConstruct

Issue 7276050: Change startup ABI for untrusted code to be C-compatible (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: disable bogus stack_frame.cc test for now Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | site_scons/site_tools/naclsdk.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: SConstruct
diff --git a/SConstruct b/SConstruct
index 1fb045ebbafdc2469bf6dc0cf21eca8e481412de..c160bee9702b627bfb34119744ea0620e2589c84 100755
--- a/SConstruct
+++ b/SConstruct
@@ -3086,11 +3086,15 @@ def AddImplicitLibs(env):
# The ComponentProgram method (site_scons/site_tools/component_builders.py)
# adds dependencies on env['IMPLICIT_LIBS'] if that's set.
implicit_libs = ['crt1.o', 'libnacl.a', 'libcrt_platform.a']
+ # TODO(mcgrathr): multilib nonsense defeats -B! figure out a better way.
+ if GetPlatform('targetplatform') == 'x86-32':
+ implicit_libs.append(os.path.join('32', 'crt1.o'))
if env.Bit('bitcode'):
implicit_libs += ['libehsupport.a']
else:
implicit_libs += ['crti.o', 'crtn.o']
- env['IMPLICIT_LIBS'] = ['${LIB_DIR}/%s' % file for file in implicit_libs]
+ env['IMPLICIT_LIBS'] = [env.File(os.path.join('${LIB_DIR}', file))
+ for file in implicit_libs]
# The -B<dir>/ flag is necessary to tell gcc to look for crt[1in].o there.
env.Prepend(LINKFLAGS=['-B${LIB_DIR}/'])
« no previous file with comments | « DEPS ('k') | site_scons/site_tools/naclsdk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698