src/trusted/service_runtime/nacl_config.h - Issue 7276050: Change startup ABI for untrusted code to be C-compatible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/service_runtime/nacl_config.h

Issue 7276050: Change startup ABI for untrusted code to be C-compatible (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « src/trusted/service_runtime/arch/x86_64/nacl_switch_64.S ('k') | src/trusted/service_runtime/sel_ldr_standard.c » ('j') | src/trusted/service_runtime/sel_ldr_standard.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/service_runtime/nacl_config.h

diff --git a/src/trusted/service_runtime/nacl_config.h b/src/trusted/service_runtime/nacl_config.h

index bf3cf509909d532611e8a588d803d5e5f48c4f3e..404db7f60ac27307ebbb0a259019ace9f33817c6 100644

--- a/src/trusted/service_runtime/nacl_config.h

+++ b/src/trusted/service_runtime/nacl_config.h

@@ -162,6 +162,8 @@

* must do so here as well.

# define NACL_STACK_ALIGN_MASK (0xf)

+# define NACL_STACK_GETS_ARG (1)

+# define NACL_STACK_PAD_BELOW_ALIGN (4)

# elif NACL_BUILD_SUBARCH == 64

# define NACL_USERRET_FIX (0x8)

@@ -173,6 +175,8 @@

* 3.2.2 discusses stack alignment.

# define NACL_STACK_ALIGN_MASK (0xf)

+# define NACL_STACK_GETS_ARG (0)

+# define NACL_STACK_PAD_BELOW_ALIGN (8)

# else /* NACL_BUILD_SUBARCH */

# error Unknown platform!

# endif /* NACL_BUILD_SUBARCH */

@@ -194,6 +198,8 @@

* -- the "public" stack alignment is required to be 8 bytes,

# define NACL_STACK_ALIGN_MASK (0x7)

+# define NACL_STACK_GETS_ARG (0)

+# define NACL_STACK_PAD_BELOW_ALIGN (0)

/* TODO(robertm): unify this with NACL_BLOCK_SHIFT */

/* 16 byte bundles */