Issue 7276046: Remove "modules" and "tags" of the logging CPU profiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7276046: Remove "modules" and "tags" of the logging CPU profiler. (Closed)

Created:
9 years, 5 months ago by mnaganov (inactive)

Modified:
9 years, 5 months ago

Reviewers:
Søren Thygesen Gjesse, Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Remove "modules" and "tags" of the logging CPU profiler. Modules now makes a little sense, as there is only one module. Tags was a simplistic attempt of supporting nested profiles. R=sgjesse@chromium.org BUG=859 Committed: http://code.google.com/p/v8/source/detail?r=8507

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -208 lines)			Patch
M	include/v8.h	View	2 chunks	+0 lines, -46 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+6 lines, -27 lines	0 comments	Download
M	src/debug-debugger.js	View	1 chunk	+2 lines, -13 lines	0 comments	Download
M	src/log.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/log.cc	View	3 chunks	+7 lines, -17 lines	0 comments	Download
M	src/runtime.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+2 lines, -10 lines	0 comments	Download
M	test/cctest/test-log.cc	View	3 chunks	+4 lines, -90 lines	0 comments	Download

Total messages: 3 (0 generated)

mnaganov (inactive)

Mads, sorry for burdening you, but I've found that Soeren is on a vacation.

9 years, 5 months ago (2011-07-01 09:22:01 UTC) #2

LGTM