Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Issue 7276035: Wrong name when creating new folder in bookmark editor (Closed)

Created:
9 years, 5 months ago by keishi1
Modified:
9 years, 5 months ago
CC:
chromium-reviews, mafv
Visibility:
Public.

Description

Wrong name when creating new folder in bookmark editor BUG=81141 TEST=manual test 1. Open bookmark edit sheet (ex. click on star and then the "Edit..." button) 2. Create new folder 3. Type in new name (ex. "foo") 4. Without pressing enter, click the Done button. 5. The new folder should be named "foo", not "New Folder" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
keishi1
This patch commits the file name in edit mode before closing the bookmark editor sheet ...
9 years, 5 months ago (2011-06-28 12:25:54 UTC) #1
mrossetti
LGTM Please add manual test instructions to TEST= so QA can verify that this bug ...
9 years, 5 months ago (2011-06-28 16:26:59 UTC) #2
commit-bot: I haz the power
9 years, 5 months ago (2011-06-29 03:47:17 UTC) #3
Change committed as 90926

Powered by Google App Engine
This is Rietveld 408576698