Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1618)

Side by Side Diff: chrome/browser/app_controller_mac.mm

Issue 7276030: Show singleton tab instead of opening multiple help tabs. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/browser.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/app_controller_mac.h" 5 #import "chrome/browser/app_controller_mac.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/file_path.h" 9 #include "base/file_path.h"
10 #include "base/mac/foundation_util.h" 10 #include "base/mac/foundation_util.h"
(...skipping 806 matching lines...) Expand 10 before | Expand all | Expand 10 after
817 Browser::OpenDownloadsWindow(lastProfile); 817 Browser::OpenDownloadsWindow(lastProfile);
818 break; 818 break;
819 case IDC_MANAGE_EXTENSIONS: 819 case IDC_MANAGE_EXTENSIONS:
820 if (Browser* browser = ActivateBrowser(lastProfile)) 820 if (Browser* browser = ActivateBrowser(lastProfile))
821 browser->ShowExtensionsTab(); 821 browser->ShowExtensionsTab();
822 else 822 else
823 Browser::OpenExtensionsWindow(lastProfile); 823 Browser::OpenExtensionsWindow(lastProfile);
824 break; 824 break;
825 case IDC_HELP_PAGE: 825 case IDC_HELP_PAGE:
826 if (Browser* browser = ActivateBrowser(lastProfile)) 826 if (Browser* browser = ActivateBrowser(lastProfile))
827 browser->OpenHelpTab(); 827 browser->ShowHelpTab();
828 else 828 else
829 Browser::OpenHelpWindow(lastProfile); 829 Browser::OpenHelpWindow(lastProfile);
830 break; 830 break;
831 case IDC_FEEDBACK: { 831 case IDC_FEEDBACK: {
832 Browser* browser = BrowserList::GetLastActive(); 832 Browser* browser = BrowserList::GetLastActive();
833 TabContents* currentTab = 833 TabContents* currentTab =
834 browser ? browser->GetSelectedTabContents() : NULL; 834 browser ? browser->GetSelectedTabContents() : NULL;
835 BugReportWindowController* controller = 835 BugReportWindowController* controller =
836 [[BugReportWindowController alloc] 836 [[BugReportWindowController alloc]
837 initWithTabContents:currentTab 837 initWithTabContents:currentTab
(...skipping 358 matching lines...) Expand 10 before | Expand all | Expand 10 after
1196 1196
1197 } // namespace browser 1197 } // namespace browser
1198 1198
1199 namespace app_controller_mac { 1199 namespace app_controller_mac {
1200 1200
1201 bool IsOpeningNewWindow() { 1201 bool IsOpeningNewWindow() {
1202 return g_is_opening_new_window; 1202 return g_is_opening_new_window;
1203 } 1203 }
1204 1204
1205 } // namespace app_controller_mac 1205 } // namespace app_controller_mac
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/browser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698