Issue 7276026: Modify the Chrome Linux zygote to support a nacl_helper executable,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7276026: Modify the Chrome Linux zygote to support a nacl_helper executable, (Closed)

Created:
9 years, 6 months ago by Brad Chen

Modified:
9 years, 6 months ago

Reviewers:

CC:
chromium-reviews, joi+watch-content_chromium.org, native-client-reviews_googlegroups.com, jam, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Modify the Chrome Linux zygote to support a nacl_helper executable, supporting a special address space layout as required by NaCl on ARM and ATOM CPUs. In passing, simplify some shared elements of launching NaCl modules in Chrome. This is an update to a previously reverted CL. Please see http://codereview.chromium.org/6995121 for the earlier reviews. Patching nacl_helper CL into fresh branch. BUG=nativeclient:480 TEST=nativeclient in-browser tests on Linux, ChromeOS

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+648 lines, -255 lines)			Patch
M	base/process_util.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	base/process_util_posix.cc	View	4 chunks	+31 lines, -4 lines	0 comments	Download
M	chrome/app/chrome_main.cc	View	3 chunks	+10 lines, -2 lines	0 comments	Download
A	chrome/common/nacl_fork_delegate_linux.h	View	1 chunk	+37 lines, -0 lines	0 comments	Download
A	chrome/common/nacl_helper_linux.h	View	1 chunk	+46 lines, -0 lines	0 comments	Download
M	chrome/common/nacl_types.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/nacl.gypi	View	3 chunks	+22 lines, -2 lines	0 comments	Download
A	chrome/nacl/nacl_fork_delegate_linux.cc	View	1 chunk	+113 lines, -0 lines	0 comments	Download
A	chrome/nacl/nacl_helper_linux.cc	View	1 chunk	+161 lines, -0 lines	0 comments	Download
D	chrome/nacl/nacl_launcher_thread.h	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	chrome/nacl/nacl_launcher_thread.cc	View	1 chunk	+0 lines, -131 lines	0 comments	Download
A	chrome/nacl/nacl_listener.h	View	1 chunk	+31 lines, -0 lines	0 comments	Download
A +	chrome/nacl/nacl_listener.cc	View	4 chunks	+33 lines, -29 lines	0 comments	Download
M	chrome/nacl/nacl_main.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	content/browser/child_process_launcher.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/zygote_host_linux.h	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	content/browser/zygote_host_linux.cc	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	content/browser/zygote_main_linux.cc	View	13 chunks	+73 lines, -35 lines	0 comments	Download
M	content/common/content_switches.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/common/content_switches.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/common/sandbox_methods_linux.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A	content/common/zygote_fork_delegate_linux.h	View	1 chunk	+49 lines, -0 lines	0 comments	Download