Issue 7276009: Add content-security-policy directive to chrome://crashes page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7276009: Add content-security-policy directive to chrome://crashes page. (Closed)

Created:
9 years, 5 months ago by Tom Sepez

Modified:
9 years, 5 months ago

Reviewers:
Evan Stade, abarth-chromium

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add content-security-policy directive to chrome://crashes page. TEST=chrome://crashes renders, and special_tabs.py passes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91583

Patch Set 2 : '' #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -65 lines)			Patch
M	chrome/browser/browser_resources.grd	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/crashes.html	View	1	2 chunks	+9 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/crashes_ui.cc	View	1	3 chunks	+21 lines, -62 lines	0 comments	Download
M	chrome/test/functional/special_tabs.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

http://codereview.chromium.org/7276009/diff/1/chrome/browser/ui/webui/crashes_ui.cc File chrome/browser/ui/webui/crashes_ui.cc (right): http://codereview.chromium.org/7276009/diff/1/chrome/browser/ui/webui/crashes_ui.cc#newcode71 chrome/browser/ui/webui/crashes_ui.cc:71: void CrashesUIHTMLSource::StartDataRequest(const std::string& path, didn't you change this interface ...

9 years, 5 months ago (2011-06-30 23:25:22 UTC) #2

Tom Sepez

Yes, this needs to change in light of the other CL. I'll ping you again ...

9 years, 5 months ago (2011-06-30 23:27:30 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 7276009: Add content-security-policy directive to chrome://crashes page. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages