Detect Kaspersky SSL MITM and give a helpful error message.

Detect Kaspersky SSL MITM and give a helpful error message.

BUG=86208
TEST=Install Kaspersky Internet security and configure SSL MITM. Navigate to an HTTPS page. Check that the error message is helpful and not generic.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91298

[agl, 2011-06-28 21:37:32]

This mostly mirrors the ESET code, so I suspect that it's correct. However, I
can only test on Windows by downloading a binary from the builders.

[wtc, 2011-06-30 14:26:25]

LGTM.

http://codereview.chromium.org/7275027/diff/2001/net/socket/ssl_client_socket...
File net/socket/ssl_client_socket_nss.cc (right):

http://codereview.chromium.org/7275027/diff/2001/net/socket/ssl_client_socket...
net/socket/ssl_client_socket_nss.cc:1886: }
Nit: since disabling False Start doesn't help, it seems that
we should detect Kaspersky products outside the if (false_start)
block.

Since Chrome enables False Start by default, this makes
little difference in practice.

[agl, 2011-07-01 14:34:42]

http://codereview.chromium.org/7275027/diff/2001/net/socket/ssl_client_socket...
File net/socket/ssl_client_socket_nss.cc (right):

http://codereview.chromium.org/7275027/diff/2001/net/socket/ssl_client_socket...
net/socket/ssl_client_socket_nss.cc:1886: }
On 2011/06/30 14:26:25, wtc wrote:
> Nit: since disabling False Start doesn't help, it seems that
> we should detect Kaspersky products outside the if (false_start)
> block.

Done. It's still within an #ifdef SSL_ENABLE_FALSE_START, but that'll always be
true on Windows.

[wtc, 2011-07-01 15:56:00]

LGTM.

[commit-bot: I haz the power, 2011-07-01 16:22:35]

Change committed as 91298