Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 7275026: Revert 90820 - Multi-Profiles: New Profile Setup UI (Closed)

Created:
9 years, 5 months ago by sail
Modified:
9 years, 5 months ago
Reviewers:
sail
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

Revert 90820 - Multi-Profiles: New Profile Setup UI This change adds DOM UI to setup a new profile. When the user clicks Wrench Menu -> New Profile the following happens: 1 we create a new profile and give it a good default name and icon 2 we open a browser window and navigate it to chrome://newprofile 3 user customizes the name and icon if they wish and then click Create 4 we navigate to the new tab page where we optionally show the Sign In To Sync promo page This change implements 3 and 4. Screenshots: - http://www.dropmocks.com/mWxdW BUG=None TEST=Navigated to chrome://newprofile and verified that things looked ok Review URL: http://codereview.chromium.org/7256002 TBR=sail@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -586 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 4 chunks +12 lines, -28 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 2 chunks +0 lines, -11 lines 0 comments Download
D chrome/browser/resources/new_profile.css View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/resources/new_profile.html View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/resources/new_profile.js View 1 chunk +0 lines, -73 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_data_source.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_data_source.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_factory.cc View 2 chunks +0 lines, -8 lines 0 comments Download
D chrome/browser/ui/webui/new_profile_dom_handler.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/ui/webui/new_profile_dom_handler.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/ui/webui/new_profile_ui.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/ui/webui/new_profile_ui.cc View 1 chunk +0 lines, -131 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/url_constants.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sail
9 years, 5 months ago (2011-06-28 20:07:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698