PseudoTcp to expose settings of nagling and ACK delay

remoting/protocol/jingle_session.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/jingle_session.h"
 
 #include "base/message_loop.h"
 #include "base/rand_util.h"
 #include "crypto/hmac.h"
 #include "crypto/rsa_private_key.h"
@@ skipping 27 matching lines @@
 
 const char kControlChannelName[] = "control";
 const char kEventChannelName[] = "event";
 const char kVideoChannelName[] = "video";
 const char kVideoRtpChannelName[] = "videortp";
 const char kVideoRtcpChannelName[] = "videortcp";
 
 const int kMasterKeyLength = 16;
 const int kChannelKeyLength = 16;
 
+// 10 milliseconds of ACK delay is choosen to lower network latency
+// and don't overwhelm the network with ACK packets.

[Wez, 2011/06/28 19:27:18]

nit: It's chosen to balance the extra latency against the reduced load due to
ACK traffic.

+const int kTcpAckDelayMilliseconds = 10;
+
 // Helper method to create a SSL client socket.
 net::SSLClientSocket* CreateSSLClientSocket(
     net::StreamSocket* socket, scoped_refptr<net::X509Certificate> cert,
     net::CertVerifier* cert_verifier) {
   net::SSLConfig ssl_config;
   ssl_config.cached_info_enabled = false;
   ssl_config.false_start_enabled = false;
   ssl_config.ssl3_enabled = true;
   ssl_config.tls1_enabled = true;
 
@@ skipping 386 matching lines @@
 
   if (!closed_) {
     // Set state to CONNECTING if the session is being accepted.
     SetState(CONNECTING);
   }
 }
 
 bool JingleSession::EstablishPseudoTcp(
     net::Socket* channel,
     scoped_ptr<net::StreamSocket>* stream) {
-  stream->reset(new jingle_glue::PseudoTcpAdapter(channel));
+  jingle_glue::PseudoTcpAdapter* adapter =
+      new jingle_glue::PseudoTcpAdapter(channel);
+  adapter->SetAckDelay(kTcpAckDelayMilliseconds);
+  adapter->SetNoDelay(false);
+
+  stream->reset(adapter);
   int result = (*stream)->Connect(&connect_callback_);
   return (result == net::OK) || (result == net::ERR_IO_PENDING);
 }
 
 bool JingleSession::EstablishSSLConnection(
     net::StreamSocket* socket,
     scoped_ptr<net::StreamSocket>* ssl_socket) {
   DCHECK(socket);
   DCHECK(socket->IsConnected());
   if (cricket_session_->initiator()) {
@@ skipping 180 matching lines @@
 
     state_ = new_state;
     if (!closed_ && state_change_callback_.get())
       state_change_callback_->Run(new_state);
   }
 }
 
 }  // namespace protocol
 
 }  // namespace remoting