Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 7275022: Explicitly pass the closure when allocating a catch or with context. (Closed)

Created:
9 years, 5 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Explicitly pass the closure when allocating a catch or with context. Before: allocation of a catch or with context fetched the closure to store in the context from the previous context in the context chain. Now: the closure is passed explicitly. R=ager@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -29 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/factory.h View 1 chunk +5 lines, -3 lines 0 comments Download
M src/factory.cc View 1 chunk +11 lines, -6 lines 0 comments Download
M src/full-codegen.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/full-codegen.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/heap.h View 1 chunk +5 lines, -3 lines 0 comments Download
M src/heap.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime.cc View 6 chunks +35 lines, -9 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
The old behavior assumed that the previous context had the appropriate closure. This would not ...
9 years, 5 months ago (2011-06-28 17:38:44 UTC) #1
Mads Ager (chromium)
9 years, 5 months ago (2011-06-29 07:31:47 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698