Install from disk image: eject original disk image volume and trash disk image file

Install from disk image: eject original disk image volume and trash disk image
file after installation.

BUG=87622
TEST=Install from disk image. Remove /Applications/Google Chrome.app (or
     /Applications/Google Chrome Canary.app if using the Canary). Launch a
     copy on a read-only disk image without dragging it off of the disk image.
     At launch, a dialog box asking you to install should appear. Choose to
     install. At the completion of installation, Chrome should relaunch from
     its installed-on-disk location in /Applications, the disk image should
     be unmounted and ejected, and the disk image file should be placed in the
     Trash.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90786

[Mark Mentovai, 2011-06-27 22:29:24]

Avi because you’ve recently worked with DiskArbitration.

Robert because you asked if we could do this.

[Avi (use Gerrit), 2011-06-27 23:28:09]

http://codereview.chromium.org/7275009/diff/1/chrome/browser/mac/install_from...
File chrome/browser/mac/install_from_dmg.mm (right):

http://codereview.chromium.org/7275009/diff/1/chrome/browser/mac/install_from...
chrome/browser/mac/install_from_dmg.mm:97: // present, it will be set to the
pathname to disk image file.
With what encoding? Unlike device paths, disk image paths are possibly
non-ASCII. Please determine that and document it.

"set to the pathname _of_ the disk image file."

http://codereview.chromium.org/7275009/diff/1/chrome/browser/mac/install_from...
chrome/browser/mac/install_from_dmg.mm:121: LOG(WARNING) << "image-path:
expected NSData, observed "
well.... you expected a CFData, not an NSData.

http://codereview.chromium.org/7275009/diff/1/chrome/browser/mac/install_from...
chrome/browser/mac/install_from_dmg.mm:541: DADiskUnmount(disk, options,
SynchronousDACallbackAdapter, &callback_data);
Does this work in the general case? In certain error cases DA calls will
immediately call back on the thread making the call. In this case, for example,
DADiskUnmount might immediately callback, and SynchronousDACallbackAdapter will
stop the current runloop. On return from DADiskUnmount, the call to
SynchronousDAOperation will start the runloop. Exactly the wrong order.

This was solved in the recovery tool with recursive mutexes; perhaps that will
work for you, perhaps not. See the source at
http://s/?dir=//depot/google3/googleclient/chrome/chromeos_recovery/mac/Chrom...
for reference if you want.

http://codereview.chromium.org/7275009/diff/1/chrome/browser/mac/install_from...
chrome/browser/mac/install_from_dmg.mm:549: return
SynchronousDAOperation("DADiskEject", &callback_data);
ditto

http://codereview.chromium.org/7275009/diff/1/chrome/browser/mac/install_from...
chrome/browser/mac/install_from_dmg.mm:610: OSStatus status =
FSPathMoveObjectToTrashSync(disk_image_path.c_str(),
Is disk_image_path UTF-8? See my earlier comment.

http://codereview.chromium.org/7275009/diff/1/chrome/browser/mac/relauncher.cc
File chrome/browser/mac/relauncher.cc (right):

http://codereview.chromium.org/7275009/diff/1/chrome/browser/mac/relauncher.c...
chrome/browser/mac/relauncher.cc:376: // relaunching.) From this point on, only
clean-up tasks should occur, and
Period outside of the parentheses.

[Avi (use Gerrit), 2011-06-27 23:45:23]

LGTM with fix.

[Avi (use Gerrit), 2011-06-27 23:47:43]

On 2011/06/27 23:45:23, Avi wrote:
> LGTM with fix.

LGTM; you been fixed.

[Mark Mentovai, 2011-06-28 01:37:23]

Allays IBF!