Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 7275004: base: Use TEST() macro in Value unittests. (Closed)

Created:
9 years, 6 months ago by tfarina
Modified:
9 years, 5 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

base: Use TEST() macro in Value unittests. While I'm here: - Add 'base' namespace to this test file. - Remove unnecessary typedefs of testing::Test. BUG=None TEST=base_unittests R=evan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -32 lines) Patch
M base/dir_reader_posix_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M base/file_descriptor_shuffle_unittest.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M base/values_unittest.cc View 16 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
9 years, 6 months ago (2011-06-27 19:33:14 UTC) #1
tfarina
ping?
9 years, 5 months ago (2011-06-28 19:33:40 UTC) #2
Evan Martin
9 years, 5 months ago (2011-06-28 22:10:20 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698