Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 7274031: Wholesale move of debugger sources to content. (Closed)

Created:
9 years, 5 months ago by Jói
Modified:
9 years, 5 months ago
Reviewers:
brettw, jam
CC:
chromium-reviews, Avi (use Gerrit), jam, Erik does not do reviews, Paweł Hajdan Jr., kkania, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Wholesale move of debugger sources to content. Other references are modified only to point to the new location. Follow-up changes will move build rules for the debugger into content. This adds a somewhat permissive DEPS file to content/browser/debugger. Follow-up work will whittle that down to zero dependencies on chrome/. BUG=84078 TEST=existing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90912

Patch Set 1 #

Patch Set 2 : Add OWNERS and DEPS. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+535 lines, -7438 lines) Patch
M chrome/browser/automation/automation_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/debugger/browser_list_tabcontents_provider.h View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/debugger/browser_list_tabcontents_provider.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/debugger/debugger_host.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/debugger/debugger_remote_service.h View 1 chunk +0 lines, -124 lines 0 comments Download
D chrome/browser/debugger/debugger_remote_service.cc View 1 chunk +0 lines, -336 lines 0 comments Download
D chrome/browser/debugger/devtools_client_host.h View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/debugger/devtools_client_host.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/debugger/devtools_file_util.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/debugger/devtools_file_util.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/browser/debugger/devtools_handler.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/debugger/devtools_handler.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/debugger/devtools_http_protocol_handler.h View 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/browser/debugger/devtools_http_protocol_handler.cc View 1 chunk +0 lines, -531 lines 0 comments Download
D chrome/browser/debugger/devtools_manager.h View 1 chunk +0 lines, -173 lines 0 comments Download
D chrome/browser/debugger/devtools_manager.cc View 1 chunk +0 lines, -466 lines 0 comments Download
D chrome/browser/debugger/devtools_manager_unittest.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/debugger/devtools_netlog_observer.h View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/debugger/devtools_netlog_observer.cc View 1 chunk +0 lines, -294 lines 0 comments Download
D chrome/browser/debugger/devtools_protocol_handler.h View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/debugger/devtools_protocol_handler.cc View 1 chunk +0 lines, -126 lines 0 comments Download
D chrome/browser/debugger/devtools_remote.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/debugger/devtools_remote_listen_socket.h View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/debugger/devtools_remote_listen_socket.cc View 1 chunk +0 lines, -258 lines 0 comments Download
D chrome/browser/debugger/devtools_remote_listen_socket_unittest.h View 1 chunk +0 lines, -129 lines 0 comments Download
D chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc View 1 chunk +0 lines, -383 lines 0 comments Download
D chrome/browser/debugger/devtools_remote_message.h View 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/browser/debugger/devtools_remote_message.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/debugger/devtools_remote_message_unittest.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/debugger/devtools_remote_service.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/debugger/devtools_remote_service.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/debugger/devtools_sanity_unittest.cc View 1 chunk +0 lines, -329 lines 0 comments Download
D chrome/browser/debugger/devtools_toggle_action.h View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/browser/debugger/devtools_window.h View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/debugger/devtools_window.cc View 1 chunk +0 lines, -474 lines 0 comments Download
D chrome/browser/debugger/extension_ports_remote_service.h View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/debugger/extension_ports_remote_service.cc View 1 chunk +0 lines, -385 lines 0 comments Download
D chrome/browser/debugger/frontend/devtools_frontend.html View 1 chunk +0 lines, -142 lines 0 comments Download
D chrome/browser/debugger/frontend/devtools_frontend_resources.grd View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/debugger/inspectable_tab_proxy.h View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/browser/debugger/inspectable_tab_proxy.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D chrome/browser/debugger/manual_tests/console-call-line-numbers.html View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/browser/debugger/manual_tests/debugger-exception-on-load.html View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/browser/debugger/manual_tests/debugger-execution-while-paused.html View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/debugger/manual_tests/debugger-fake-workers.html View 1 chunk +0 lines, -102 lines 0 comments Download
D chrome/browser/debugger/manual_tests/debugger-pause-on-else-statements.html View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/debugger/manual_tests/debugger-pause-on-for-in-statements.html View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/debugger/manual_tests/debugger-pause-on-for-statements.html View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/debugger/manual_tests/debugger-step-on-do-while-statements.html View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/debugger/manual_tests/debugger-step-on-for-in-statements.html View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/debugger/manual_tests/debugger-step-on-for-statements.html View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/debugger/manual_tests/debugger-step-on-while-statements.html View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/debugger/manual_tests/debugger-watch-expressions.html View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/debugger/manual_tests/dom-mutation.html View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/debugger/manual_tests/element-styles.html View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/debugger/manual_tests/error-warning-count.html View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/debugger/manual_tests/event-listeners.html View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/debugger/manual_tests/heap-profiler-test-basic-grid-functionality.html View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/debugger/manual_tests/heap-profiler-test-snapshots-comparison.html View 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/debugger/manual_tests/highlight-nodes.html View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/debugger/manual_tests/highlight-source-line.html View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/debugger/manual_tests/profiler-test-basic-grid-functionality.html View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/debugger/manual_tests/profiler-test-console-control.html View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/debugger/manual_tests/profiler-test-focus-and-exclude.html View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/browser/debugger/manual_tests/profiler-test-re-opening.html View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/debugger/manual_tests/resources/fib.js View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/debugger/manual_tests/resources/loop-statements.js View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/debugger/manual_tests/resources/mutate-frame.html View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/browser/debugger/manual_tests/resources/mutate-frame-2.html View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/debugger/manual_tests/resources/primes.js View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/debugger/manual_tests/resources/script-console-calls.js View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/browser/debugger/manual_tests/resources/worker-primes.js View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_debugger_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_devtools_bridge.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_devtools_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_devtools_browsertests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extensions_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/dev_tools_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/extension_settings_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 3 chunks +34 lines, -33 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 8 chunks +8 lines, -6 lines 0 comments Download
M chrome/test/in_process_browser_test.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/DEPS View 1 2 chunks +1 line, -5 lines 0 comments Download
M content/browser/content_browser_client.h View 1 9 chunks +31 lines, -30 lines 0 comments Download
D content/browser/content_browser_client.cc View 1 1 chunk +0 lines, -184 lines 0 comments Download
A content/browser/debugger/DEPS View 1 1 chunk +37 lines, -0 lines 0 comments Download
A content/browser/debugger/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + content/browser/debugger/browser_list_tabcontents_provider.h View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/debugger/browser_list_tabcontents_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/debugger/debugger_host.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/debugger_remote_service.h View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/debugger/debugger_remote_service.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/debugger/devtools_client_host.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/devtools_client_host.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/debugger/devtools_file_util.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/devtools_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/debugger/devtools_handler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/devtools_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/debugger/devtools_http_protocol_handler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/devtools_http_protocol_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/debugger/devtools_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/debugger/devtools_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/debugger/devtools_manager_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/debugger/devtools_netlog_observer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/devtools_netlog_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/debugger/devtools_protocol_handler.h View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/debugger/devtools_protocol_handler.cc View 1 chunk +7 lines, -7 lines 0 comments Download
A + content/browser/debugger/devtools_remote.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/devtools_remote_listen_socket.h View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/debugger/devtools_remote_listen_socket.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/debugger/devtools_remote_listen_socket_unittest.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/debugger/devtools_remote_listen_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/debugger/devtools_remote_message.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/devtools_remote_message.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/debugger/devtools_remote_message_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/debugger/devtools_remote_service.h View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/debugger/devtools_remote_service.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/debugger/devtools_sanity_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/debugger/devtools_toggle_action.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/devtools_window.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/debugger/devtools_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/browser/debugger/extension_ports_remote_service.h View 1 chunk +1 line, -1 line 2 comments Download
A + content/browser/debugger/extension_ports_remote_service.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/debugger/frontend/devtools_frontend.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/frontend/devtools_frontend_resources.grd View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/inspectable_tab_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/debugger/inspectable_tab_proxy.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/debugger/manual_tests/console-call-line-numbers.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/debugger-exception-on-load.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/debugger-execution-while-paused.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/debugger-fake-workers.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/debugger-pause-on-else-statements.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/debugger-pause-on-for-in-statements.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/debugger-pause-on-for-statements.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/debugger-step-on-do-while-statements.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/debugger-step-on-for-in-statements.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/debugger-step-on-for-statements.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/debugger-step-on-while-statements.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/debugger-watch-expressions.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/dom-mutation.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/element-styles.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/error-warning-count.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/event-listeners.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/heap-profiler-test-basic-grid-functionality.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/heap-profiler-test-snapshots-comparison.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/highlight-nodes.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/highlight-source-line.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/profiler-test-basic-grid-functionality.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/profiler-test-console-control.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/profiler-test-focus-and-exclude.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/profiler-test-re-opening.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/resources/fib.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/resources/loop-statements.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/resources/mutate-frame.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/resources/mutate-frame-2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/resources/primes.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/resources/script-console-calls.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/debugger/manual_tests/resources/worker-primes.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A content/browser/mock_content_browser_client.h View 1 1 chunk +105 lines, -0 lines 0 comments Download
A + content/browser/mock_content_browser_client.cc View 1 5 chunks +44 lines, -42 lines 0 comments Download
M content/browser/renderer_host/async_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/sync_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_instance_unittest.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/content_client.h View 1 1 chunk +9 lines, -9 lines 0 comments Download
M content/common/content_client.cc View 1 1 chunk +0 lines, -28 lines 0 comments Download
M content/content_browser.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/content_utility.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/plugin/content_plugin_client.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/content_renderer_client.h View 1 1 chunk +20 lines, -20 lines 0 comments Download
D content/renderer/content_renderer_client.cc View 1 1 chunk +0 lines, -100 lines 0 comments Download
A content/renderer/mock_content_renderer_client.h View 1 1 chunk +58 lines, -0 lines 0 comments Download
A content/renderer/mock_content_renderer_client.cc View 1 1 chunk +105 lines, -0 lines 0 comments Download
M content/utility/content_utility_client.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
D content/utility/content_utility_client.cc View 1 1 chunk +0 lines, -16 lines 0 comments Download
M tools/grit/resource_ids View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Jói
Brett, could you LGTM this in John's absence? By John's advice though, I will try ...
9 years, 5 months ago (2011-06-28 21:07:27 UTC) #1
Jói
9 years, 5 months ago (2011-06-29 02:09:47 UTC) #2
Jói
John, will TBR to you as discussed.
9 years, 5 months ago (2011-06-29 02:10:06 UTC) #3
brettw
LGTM http://codereview.chromium.org/7274031/diff/177/content/browser/debugger/extension_ports_remote_service.h File content/browser/debugger/extension_ports_remote_service.h (right): http://codereview.chromium.org/7274031/diff/177/content/browser/debugger/extension_ports_remote_service.h#newcode9 content/browser/debugger/extension_ports_remote_service.h:9: #ifndef CHROME_BROWSER_DEBUGGER_EXTENSION_PORTS_REMOTE_SERVICE_H_ All of the include guards in ...
9 years, 5 months ago (2011-06-29 16:44:55 UTC) #4
Jói
9 years, 5 months ago (2011-06-30 15:48:11 UTC) #5
http://codereview.chromium.org/7274031/diff/177/content/browser/debugger/exte...
File content/browser/debugger/extension_ports_remote_service.h (right):

http://codereview.chromium.org/7274031/diff/177/content/browser/debugger/exte...
content/browser/debugger/extension_ports_remote_service.h:9: #ifndef
CHROME_BROWSER_DEBUGGER_EXTENSION_PORTS_REMOTE_SERVICE_H_
On 2011/06/29 16:44:55, brettw wrote:
> All of the include guards in this new directory are wrong. Can you do a pass
> where you fix all of them?

Doh, that was on my list but I forgot to do it.  Coming right up.

Powered by Google App Engine
This is Rietveld 408576698