PrintPreview: Implement GetMetafileForCurrentPage() function in PdfMetafileSkia.

PrintPreview: Implement GetMetafileForCurrentPage() function in PdfMetafileSkia.

This function is required for  print preview pipeline sequence. 

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91269

[vandebo (ex-Chrome), 2011-06-29 20:23:45]

http://codereview.chromium.org/7274026/diff/1/printing/pdf_metafile_skia.cc
File printing/pdf_metafile_skia.cc (right):

http://codereview.chromium.org/7274026/diff/1/printing/pdf_metafile_skia.cc#n...
printing/pdf_metafile_skia.cc:54: if (did_finish_page_)
I think this should just be DCHECK(did_finish_page_)

http://codereview.chromium.org/7274026/diff/1/printing/pdf_metafile_skia.cc#n...
printing/pdf_metafile_skia.cc:98: if (!did_finish_page_ &&
data_->current_page_.get())
Don't (shouldn't) need to current_page_.get() check.

http://codereview.chromium.org/7274026/diff/1/printing/pdf_metafile_skia.h
File printing/pdf_metafile_skia.h (right):

http://codereview.chromium.org/7274026/diff/1/printing/pdf_metafile_skia.h#ne...
printing/pdf_metafile_skia.h:73: // Helper function to get the metafile for
current page. This is called from
We can probably give a better description of this method:
Return a new metafile containing just the current page in draft mode.

http://codereview.chromium.org/7274026/diff/1/printing/pdf_metafile_skia.h#ne...
printing/pdf_metafile_skia.h:84: mutable bool did_finish_page_;
Why do we have mutable fields?

[kmadhusu, 2011-06-30 06:10:55]

http://codereview.chromium.org/7274026/diff/1/printing/pdf_metafile_skia.cc
File printing/pdf_metafile_skia.cc (right):

http://codereview.chromium.org/7274026/diff/1/printing/pdf_metafile_skia.cc#n...
printing/pdf_metafile_skia.cc:54: if (did_finish_page_)
On 2011/06/29 20:23:45, vandebo wrote:
> I think this should just be DCHECK(did_finish_page_)

Renamed the variable to outstanding_finish_page_.

http://codereview.chromium.org/7274026/diff/1/printing/pdf_metafile_skia.cc#n...
printing/pdf_metafile_skia.cc:98: if (!did_finish_page_ &&
data_->current_page_.get())
On 2011/06/29 20:23:45, vandebo wrote:
> Don't (shouldn't) need to current_page_.get() check.

Done.

http://codereview.chromium.org/7274026/diff/1/printing/pdf_metafile_skia.h
File printing/pdf_metafile_skia.h (right):

http://codereview.chromium.org/7274026/diff/1/printing/pdf_metafile_skia.h#ne...
printing/pdf_metafile_skia.h:73: // Helper function to get the metafile for
current page. This is called from
On 2011/06/29 20:23:45, vandebo wrote:
> We can probably give a better description of this method:
> Return a new metafile containing just the current page in draft mode.

Done.

http://codereview.chromium.org/7274026/diff/1/printing/pdf_metafile_skia.h#ne...
printing/pdf_metafile_skia.h:84: mutable bool did_finish_page_;
On 2011/06/29 20:23:45, vandebo wrote:
> Why do we have mutable fields?

Removed.

[vandebo (ex-Chrome), 2011-06-30 22:22:47]

code review isn't taking comments from me now. LGTM with a few nits.

pdf_metafile_skia.h:81   nit: page_outstanding_
pdf_metafile_skia.cc:55 nit: this line isn't necessary.
pdf_metafile_skia.cc:257 nit: missing space between argument.

On Thu, Jun 30, 2011 at 10:58 AM, <kmadhusu@chromium.org> wrote:

>
http://codereview.chromium.**org/7274026/<http://codereview.chromium.org/7274...
>

[kmadhusu, 2011-07-01 00:03:54]

Addressed nits.

Thanks.

[commit-bot: I haz the power, 2011-07-01 05:10:46]

Change committed as 91269