Issue 7273092: Fix platform-solaris after isolate changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7273092: Fix platform-solaris after isolate changes. (Closed)

Created:
9 years, 5 months ago by Mads Ager (chromium)

Modified:
9 years, 5 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix platform-solaris after isolate changes. Patch from http://code.google.com/p/v8/issues/detail?id=1509. R=ager@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8476

Patch Set 1 #

Total comments: 1

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+137 lines, -85 lines)			Patch
	M	src/platform-solaris.cc	View		7 chunks	+137 lines, -85 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 5 months ago (2011-06-30 07:20:46 UTC) #2

LGTM

I don't think this is fully up to date yet, but I will commit this to get your
going.

http://codereview.chromium.org/7273092/diff/1/src/platform-solaris.cc
File src/platform-solaris.cc (right):

http://codereview.chromium.org/7273092/diff/1/src/platform-solaris.cc#newcode691
src/platform-solaris.cc:691: virtual void Run() {
The Run method has not been updated to completely match the platform-linux one.
In particular, I don't think CPU profiling will work on solaris at this point.

Expand Messages | Collapse Messages