Upstream android net related code (part 2)

Upstream android net related code (part 2)

Add std:: to find() and replace() calls

BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91728

[Randy Smith (Not in Mondays), 2011-07-01 17:40:28]

I have no real expertise in this code, so I'm removing myself from the reviewer
list.

[darin (slow to review), 2011-07-01 17:46:21]

http://codereview.chromium.org/7273081/diff/1/net/url_request/url_request.h
File net/url_request/url_request.h (right):

http://codereview.chromium.org/7273081/diff/1/net/url_request/url_request.h#n...
net/url_request/url_request.h:204: // Called when an X-Auto-Login header is
seen.  |value| is the
i don't know why we need the network stack to know about the non-standard
X-Auto-Login header.  this seems like something that should be handled at a
higher level.

http://codereview.chromium.org/7273081/diff/1/net/url_request/url_request_htt...
File net/url_request/url_request_http_job.cc (right):

http://codereview.chromium.org/7273081/diff/1/net/url_request/url_request_htt...
net/url_request/url_request_http_job.cc:762: CheckForXAutoLogin();
why can't you just do X-Auto-Login processing at a higher level, from within the
OnResponseStarted callback?

[wtc, 2011-07-01 23:42:23]

I agree with darin that the "X-Auto-Login" related code should
be removed from the network stack.

[willchan no longer on Chromium, 2011-07-02 18:10:15]

http://codereview.chromium.org/7273081/diff/1/net/url_request/url_request_htt...
File net/url_request/url_request_http_job.cc (right):

http://codereview.chromium.org/7273081/diff/1/net/url_request/url_request_htt...
net/url_request/url_request_http_job.cc:762: CheckForXAutoLogin();
On 2011/07/01 17:46:21, darin wrote:
> why can't you just do X-Auto-Login processing at a higher level, from within
the
> OnResponseStarted callback?

+1

[michaelbai, 2011-07-06 18:30:32]

Removed x-auto-login related code which will be moved to higher level in a
different CL.

Now this patch is very simple, please review it again.

[darin (slow to review), 2011-07-06 19:30:01]

LGTM, but I am not an OWNER

[wtc, 2011-07-07 02:30:24]

LGTM.

Please update your CL's commit message to say
"Add std:: to find() and replace() calls".