Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_mac.mm

Issue 7273056: [Mac] Create transparent cursor when given empty custom data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Handle empty size. Revert breakpad logging. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/glue/webcursor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/chrome/browser/renderer_host/render_widget_host_view_mac.mm b/chrome/browser/renderer_host/render_widget_host_view_mac.mm
index 8b12cf0b632dcabd6d682e9aae59567b108e16f0..6174c29bdc59b4b00320fc80c7c185de236001e4 100644
--- a/chrome/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/chrome/browser/renderer_host/render_widget_host_view_mac.mm
@@ -15,7 +15,6 @@
#include "base/string_util.h"
#include "base/sys_info.h"
#include "base/sys_string_conversions.h"
-#import "chrome/app/breakpad_mac.h"
#include "chrome/browser/browser_trial.h"
#import "chrome/browser/renderer_host/accelerated_plugin_view_mac.h"
#import "chrome/browser/renderer_host/text_input_client_mac.h"
@@ -43,7 +42,6 @@
#import "third_party/mozilla/ComplexTextInputPanel.h"
#include "third_party/skia/include/core/SkColor.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/mac/WebInputEventFactory.h"
-#include "third_party/WebKit/Source/WebKit/chromium/public/WebCursorInfo.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebInputEvent.h"
#include "ui/gfx/point.h"
#include "ui/gfx/surface/io_surface_support_mac.h"
@@ -481,17 +479,6 @@ void RenderWidgetHostViewMac::UpdateCursorIfNecessary() {
if ([event window] != [cocoa_view_ window])
return;
- // TODO(shess): Store additional information in breakpad dumps for
- // debugging http://crbug.com/73356 .
- scoped_ptr<ScopedCrashKey> key;
- if (current_cursor_.IsCustom()) {
- NSString* kCrashKey = @"custom-cursor-size";
- const gfx::Size size = current_cursor_.custom_size();
- NSString* crashValue =
- [NSString stringWithFormat:@"{%d, %d}", size.width(), size.height()];
- key.reset(new ScopedCrashKey(kCrashKey, crashValue));
- }
-
NSCursor* ns_cursor = current_cursor_.GetCursor();
[ns_cursor set];
}
« no previous file with comments | « no previous file | webkit/glue/webcursor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698