Base: Don't delete the previous command line when calling

base/command_line.cc

Index: base/command_line.cc
===================================================================
--- base/command_line.cc	(revision 90612)
+++ base/command_line.cc	(working copy)
@@ -168,7 +168,13 @@
 
 // static
 void CommandLine::Init(int argc, const char* const* argv) {
-  delete current_process_commandline_;
+  if (current_process_commandline_) {

[msw, 2011/06/28 23:19:42]

I don't think this should fail silently. There might be some clients relying on
this behavior, even if it's incorrect. If this is the right behavior change, add
a DCHECK or a CHECK.

[rvargas (doing something else), 2011/06/28 23:57:35]

I was going to CHECK... except that it will defeat the purpose of the change,
because it happens for a build configuration. And I don't want to add code
specifically for one configuration when I'm just following the documented
behavior.

+    // If this is intentional, Reset() must be called first. If we are using
+    // the shared build mode, we have to share a single object across multiple
+    // shared libraries.
+    return;
+  }
+
   current_process_commandline_ = new CommandLine(NO_PROGRAM);
 #if defined(OS_WIN)
   current_process_commandline_->ParseFromString(::GetCommandLineW());