Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: chrome/browser/ui/browser_list.h

Issue 7273038: ChromeOs: Call BrowserList::SessionEnding when shutting down via SIGTERM (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_list.h
diff --git a/chrome/browser/ui/browser_list.h b/chrome/browser/ui/browser_list.h
index 1e0192438ea2061dd327c7d86848a8e09c65a680..509df205a4e8d38ce475e937511a9ca13a000920 100644
--- a/chrome/browser/ui/browser_list.h
+++ b/chrome/browser/ui/browser_list.h
@@ -127,21 +127,15 @@ class BrowserList {
// unload handler, and the browser may or may not exit.
static void AttemptExit();
-#if defined(OS_CHROMEOS)
- // This is equivalent to AttemptUserExit, except that it always set
- // exit cleanly bit. ChroemOS checks if it can exit without user
- // interactions, so it will always exit the browser. This is used to
- // handle SIGTERM on chromeos which is a signal to force shutdown
- // the chrome.
- static void ExitCleanly();
-#endif
-
// Closes all browsers. If the session is ending the windows are closed
// directly. Otherwise the windows are closed by way of posting a WM_CLOSE
// message.
static void CloseAllBrowsers();
- // Begins shutdown of the application when the desktop session is ending.
+ // Begins shutdown of the application when the desktop session is
+ // ending. This first calls BrowserProcess::EndSession then force
+ // closes browsers, therefore any crashes after EndSession won't be
+ // included in UMA stats.
static void SessionEnding();
// Returns true if there is at least one Browser with the specified profile.
@@ -202,7 +196,7 @@ class BrowserList {
private:
// Helper method to remove a browser instance from a list of browsers
static void RemoveBrowserFrom(Browser* browser, BrowserVector* browser_list);
- static void MarkAsCleanShutdown();
+ static void MarkAsCleanShutdownInUserProfiles();
static void AttemptExitInternal();
static BrowserVector browsers_;

Powered by Google App Engine
This is Rietveld 408576698