ChromeOs: Call BrowserList::SessionEnding when shutting down via SIGTERM

chrome/browser/metrics/metrics_service.cc

Index: chrome/browser/metrics/metrics_service.cc
diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc
index cb298e5c0e2fdc6e58a4a4d35522a91544db2e8e..aa328012e498f0372faf80e1be4979d9e8609d84 100644
--- a/chrome/browser/metrics/metrics_service.cc
+++ b/chrome/browser/metrics/metrics_service.cc
@@ -1231,6 +1231,10 @@ void MetricsService::StoreUnsentLogs() {
   }
 }
 
+void MetricsService::LogCleanShutdown() {
+  RecordBooleanPrefValue(prefs::kStabilityExitedCleanly, true);

[jar (doing other things), 2011/06/29 04:00:09]

Two things: I think this should ONLY be called on teh UI thread.  This was less
of an issue when this was private (and we could assert the proper thread in the
calling code).  Since this is now public, please add an assertion that this is
on the proper thread.

Second item: This does not push the flag to the disk.  It does not even schedule
the pushing of the flag to the disk in a "coalesced push of several flags."  The
name suggests it is much more aggressive, but the code does not do more (push
immediately, or even schedule a push).  As a result, an immediate shutdown after
this call will STILL be listed as a crash in UMA.

+}
+
 void MetricsService::PreparePendingLogText() {
   DCHECK(pending_log());
   if (!compressed_log_.empty())
@@ -1480,10 +1484,6 @@ void MetricsService::LogRendererHang() {
   IncrementPrefValue(prefs::kStabilityRendererHangCount);
 }
 
-void MetricsService::LogCleanShutdown() {
-  RecordBooleanPrefValue(prefs::kStabilityExitedCleanly, true);
-}
-
 #if defined(OS_CHROMEOS)
 void MetricsService::LogChromeOSCrash(const std::string &crash_type) {
   if (crash_type == "user")