ChromeOs: Call BrowserList::SessionEnding when shutting down via SIGTERM

chrome/browser/metrics/metrics_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 //------------------------------------------------------------------------------
 // Description of the life cycle of a instance of MetricsService.
 //
 //  OVERVIEW
 //
 // A MetricsService instance is typically created at application startup.  It
@@ skipping 1213 matching lines @@
   }
 
   {
     ListPrefUpdate update(local_state, prefs::kMetricsOngoingLogs);
     ListValue* unsent_ongoing_logs = update.Get();
     StoreUnsentLogsHelper(unsent_ongoing_logs_, kMaxOngoingLogsPersisted,
                           unsent_ongoing_logs);
   }
 }
 
+void MetricsService::LogCleanShutdown() {
+  RecordBooleanPrefValue(prefs::kStabilityExitedCleanly, true);

[jar (doing other things), 2011/06/29 04:00:09]

Two things: I think this should ONLY be called on teh UI thread.  This was less
of an issue when this was private (and we could assert the proper thread in the
calling code).  Since this is now public, please add an assertion that this is
on the proper thread.

Second item: This does not push the flag to the disk.  It does not even schedule
the pushing of the flag to the disk in a "coalesced push of several flags."  The
name suggests it is much more aggressive, but the code does not do more (push
immediately, or even schedule a push).  As a result, an immediate shutdown after
this call will STILL be listed as a crash in UMA.

+}
+
 void MetricsService::PreparePendingLogText() {
   DCHECK(pending_log());
   if (!compressed_log_.empty())
     return;
   int text_size = pending_log_->GetEncodedLogSize();
 
   std::string pending_log_text;
   // Leave room for the NULL terminator.
   pending_log_->GetEncodedLog(WriteInto(&pending_log_text, text_size + 1),
                               text_size);
@@ skipping 229 matching lines @@
 }
 
 void MetricsService::LogExtensionRendererCrash() {
   IncrementPrefValue(prefs::kStabilityExtensionRendererCrashCount);
 }
 
 void MetricsService::LogRendererHang() {
   IncrementPrefValue(prefs::kStabilityRendererHangCount);
 }
 
-void MetricsService::LogCleanShutdown() {
-  RecordBooleanPrefValue(prefs::kStabilityExitedCleanly, true);
-}
-
 #if defined(OS_CHROMEOS)
 void MetricsService::LogChromeOSCrash(const std::string &crash_type) {
   if (crash_type == "user")
     IncrementPrefValue(prefs::kStabilityOtherUserCrashCount);
   else if (crash_type == "kernel")
     IncrementPrefValue(prefs::kStabilityKernelCrashCount);
   else if (crash_type == "uncleanshutdown")
     IncrementPrefValue(prefs::kStabilitySystemUncleanShutdownCount);
   else
     NOTREACHED() << "Unexpected Chrome OS crash type " << crash_type;
@@ skipping 197 matching lines @@
     thread_id = base::PlatformThread::CurrentId();
   return base::PlatformThread::CurrentId() == thread_id;
 }
 
 #if defined(OS_CHROMEOS)
 void MetricsService::StartExternalMetrics() {
   external_metrics_ = new chromeos::ExternalMetrics;
   external_metrics_->Start();
 }
 #endif